Review 12.4 Merged

84705[TASK] Reduce hard-coded `tt_content` table in StandardPreviewRenderer

Oli Bartsch CR +2 V +2 Hard +165 −100 updated 06/13/24, 19:13

Commit message

The goal here is to have a generic PreviewRenderer, which is not
tt_content specific. The StandardContentPreviewRenderer could then
extend this generic renderer. This is a pre-patch to make the
refactoring easier in the next patch.

For this to work, GridColumnItem now exposes methods to retrieve the
table from the context, the type column and the record type.

Additionally, some drive-by refactorings have been done like early
return statements and stricter checks.

The unused variable $infoArr has been removed as well.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch uploaded patch set 1 06/13/24, 19:06

  2. core-ci voted on patch set 1 V +1 06/13/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59537

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 06/13/24, 19:13

  4. Oli Bartsch merged patch set 2 06/13/24, 19:13