84707[TASK] Extract lit element for infobox into the `backend` namespace
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 30
- Build/Sources/TypeScript/backend/element/info-box.ts4renamed+4 −18
- Build/Sources/TypeScript/install/module/environment/environment-check.ts+6 −3
- Build/Sources/TypeScript/install/module/environment/folder-structure.ts+30 −8
- Build/Sources/TypeScript/install/module/environment/image-processing.ts+10 −4
- Build/Sources/TypeScript/install/module/environment/mail-test.ts+11 −4
- Build/Sources/TypeScript/install/module/maintenance/database-analyzer.ts+10 −4
- Build/Sources/TypeScript/install/module/maintenance/language-packs.ts+31 −15
- Build/Sources/TypeScript/install/module/upgrade/extension-compat-tester.ts+23 −11
- Build/Sources/TypeScript/install/module/upgrade/tca-ext-tables-check.ts+15 −9
- Build/Sources/TypeScript/install/module/upgrade/tca-migrations-check.ts+16 −13
- Build/Sources/TypeScript/install/module/upgrade/upgrade-wizards.ts+21 −6
- Build/Sources/TypeScript/install/module/abstract-interactable-module.ts+9 −2
- Build/Sources/TypeScript/install/renderable/language-packs.ts+2 −2
- Build/Sources/TypeScript/install/installer.ts+35 −8
- Build/Sources/TypeScript/install/router.ts+21 −6
- typo3/sysext/backend/Resources/Public/JavaScript/element/info-box.jsrenamed+2 −2
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/environment-check.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/folder-structure.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/image-processing.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/mail-test.js+1 −1
Show 10 more files
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/database-analyzer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/language-packs.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/extension-compat-tester.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/tca-ext-tables-check.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/tca-migrations-check.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/upgrade-wizards.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/abstract-interactable-module.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/renderable/language-packs.js+2 −2
- typo3/sysext/install/Resources/Public/JavaScript/installer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/router.js+1 −1
Review log 1725
-
Philipp Kuhlmay uploaded patch set 1 06/13/24, 19:35
-
core-ci voted on patch set 1 V +1 06/13/24, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59541
-
Benjamin Franzke commented on patch set 1 06/14/24, 07:15
-
Philipp Kuhlmay uploaded patch set 2
V +106/16/24, 14:20 -
core-ci voted on patch set 2 V +1 06/16/24, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59679
-
Philipp Kuhlmay commented on patch set 2 06/17/24, 17:03
info-box.ts:21ReplyDone -
Marcin Sągol commented on patch set 2 CR +1 V +1 06/24/24, 11:55
I have tested it in multiple places related to changed files, and it looks ok. Probably as a separate patch there should be an adjustment to support also the icon in this component and replace static HTML in some places where callout is used with this component. -
Andreas Kienast commented on patch set 2 CR -1 06/24/24, 12:47
on it, will review and rebase -
Andreas Kienast uploaded patch set 3
CR +1V +106/24/24, 12:57 -
Andreas Kienast commented on patch set 3 CR -1 06/24/24, 12:57
-1 for now, I need to check something else... -
Andreas Kienast commented on patch set 3 06/24/24, 13:06
info-box.ts:28This will very like cause trouble in the regular backend. The code ensures the element is always created in the most outer `document` that's available as it's a requirement for correctly rendered info boxes in the Install Tool. The reason is that the module is used in modals, which always reside in the `top` context. -
core-ci voted on patch set 3 V -1 06/24/24, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60173
-
Andreas Kienast uploaded patch set 4
CR -1V -106/24/24, 13:44 -
Andreas Kienast uploaded patch set 5 06/24/24, 13:46
-
Andreas Kienast commented on patch set 5 06/24/24, 13:47
info-box.ts:28ReplyDone -
core-ci voted on patch set 4 V +1 06/24/24, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60178
-
core-ci voted on patch set 5 V +1 06/24/24, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60179
-
Philipp Kuhlmay uploaded patch set 6
V +107/12/24, 10:00 -
core-ci voted on patch set 6 V +1 07/12/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61472
-
Philipp Kuhlmay uploaded patch set 7
V +109/06/24, 14:22 -
core-ci voted on patch set 7 V +1 09/06/24, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64972
-
Philipp Kuhlmay uploaded patch set 8
V +109/13/24, 09:29 -
core-ci voted on patch set 8 V +1 09/13/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65646
-
Benni Mack commented on patch set 8 04/12/25, 12:16
are we going to continue here? -
Benni Mack abandoned the change 04/13/25, 12:04
abandoned, can be revived later.
info-box.ts:21