Review main Abandoned

84707[TASK] Extract lit element for infobox into the `backend` namespace

Philipp Kuhlmay CR 0 V 0 Hard +261 −130 updated 04/13/25, 12:04

Commit message

This patch extracts the `typo3-install-infobox` component into the
backend scope and renames it to `typo3-backend-infobox` to allow its
usage in the whole TYPO3 backend.

This change makes it mandatory to remove a `document` quirk from the
component, as it was previously used in modal windows only.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 30

Show 10 more files

Review log 1725

  1. Philipp Kuhlmay uploaded patch set 1 06/13/24, 19:35

  2. core-ci voted on patch set 1 V +1 06/13/24, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59541

  3. Benjamin Franzke commented on patch set 1 06/14/24, 07:15

    info-box.ts:21

    Let's use `typo3-backend-infobox` to be in line with `typo3-backend-icon`.
  4. Philipp Kuhlmay uploaded patch set 2 V +1 06/16/24, 14:20

  5. core-ci voted on patch set 2 V +1 06/16/24, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59679

  6. Philipp Kuhlmay commented on patch set 2 06/17/24, 17:03

    info-box.ts:21 Reply

    Done
  7. Marcin Sągol commented on patch set 2 CR +1 V +1 06/24/24, 11:55

    I have tested it in multiple places related to changed files, and it looks ok. Probably as a separate patch there should be an adjustment to support also the icon in this component and replace static HTML in some places where callout is used with this component.
  8. Andreas Kienast commented on patch set 2 CR -1 06/24/24, 12:47

    on it, will review and rebase
  9. Andreas Kienast uploaded patch set 3 CR +1 V +1 06/24/24, 12:57

  10. Andreas Kienast commented on patch set 3 CR -1 06/24/24, 12:57

    -1 for now, I need to check something else...
  11. Andreas Kienast commented on patch set 3 06/24/24, 13:06

    info-box.ts:28

    This will very like cause trouble in the regular backend. The code ensures the element is always created in the most outer `document` that's available as it's a requirement for correctly rendered info boxes in the Install Tool. The reason is that the module is used in modals, which always reside in the `top` context.
  12. core-ci voted on patch set 3 V -1 06/24/24, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60173

  13. Andreas Kienast uploaded patch set 4 CR -1 V -1 06/24/24, 13:44

  14. Andreas Kienast uploaded patch set 5 06/24/24, 13:46

  15. Andreas Kienast commented on patch set 5 06/24/24, 13:47

    info-box.ts:28 Reply

    Done
  16. core-ci voted on patch set 4 V +1 06/24/24, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60178

  17. core-ci voted on patch set 5 V +1 06/24/24, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60179

  18. Philipp Kuhlmay uploaded patch set 6 V +1 07/12/24, 10:00

  19. core-ci voted on patch set 6 V +1 07/12/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61472

  20. Philipp Kuhlmay uploaded patch set 7 V +1 09/06/24, 14:22

  21. core-ci voted on patch set 7 V +1 09/06/24, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64972

  22. Philipp Kuhlmay uploaded patch set 8 V +1 09/13/24, 09:29

  23. core-ci voted on patch set 8 V +1 09/13/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65646

  24. Benni Mack commented on patch set 8 04/12/25, 12:16

    are we going to continue here?
  25. Benni Mack abandoned the change 04/13/25, 12:04

    abandoned, can be revived later.