84708[TASK] Avoid indexed_search debugMode & index_debug
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Andreas Kienast +1
Issues 1
Files 12
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+0 −1
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+0 −17
- typo3/sysext/indexed_search/Classes/Domain/Repository/AdministrationRepository.php+0 −1
- typo3/sysext/indexed_search/Classes/Indexer.php+2 −35
- typo3/sysext/indexed_search/Resources/Private/Language/locallang.xlf+0 −3
- typo3/sysext/indexed_search/Resources/Private/Language/locallang_em.xlf+0 −3
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/StatisticDetails.html+0 −5
- typo3/sysext/indexed_search/Tests/Functional/IndexerTest.php+0 −4
- typo3/sysext/indexed_search/Tests/Functional/IndexSearchRepositoryTest.php+0 −1
- typo3/sysext/indexed_search/ext_conf_template.txt+0 −3
- typo3/sysext/indexed_search/ext_tables.sql+0 −7
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+2 −0
Review log 1619
-
Christian Kuhn uploaded patch set 1 06/13/24, 20:41
-
core-ci voted on patch set 1 V +1 06/13/24, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59542
-
Christian Kuhn updated the commit message in patch set 2
V +106/14/24, 09:59 -
Andreas Kienast updated the commit message in patch set 3 06/14/24, 10:02
-
core-ci voted on patch set 2 V +1 06/14/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59590
-
Andreas Kienast voted on patch set 3 CR +1 V +1 06/14/24, 10:06
-
core-ci voted on patch set 3 V +1 06/14/24, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59592
-
Georg Ringer commented on patch set 3 06/14/24, 11:07
should we add the setting to SilentConfigurationUpgradeService? -
Christian Kuhn commented on patch set 3 06/14/24, 11:15
Reply
oehm. good point, we have no example for a detail in EXTENSIONS, though. afaik, we just rely on 'will be removed on next extension settings safe automatically' I'd say it does not harm much to keep that setting for existing instances and just ignore it. fine with you? -
Jochen Roth voted on patch set 3 CR +1 V +1 06/14/24, 12:31
-
Christian Kuhn uploaded patch set 4
CR +1V +106/14/24, 13:13 -
Christian Kuhn commented on patch set 4 06/14/24, 13:13
Reply
ok, added. -
Jochen Roth voted on patch set 4 CR +1 V +1 06/14/24, 13:14
-
Andreas Kienast voted on patch set 4 CR +1 V +1 06/14/24, 13:18
-
Christian Kuhn uploaded patch set 5
CR +1V +106/14/24, 13:23 -
Andreas Kienast voted on patch set 5 CR +1 V +1 06/14/24, 13:23
-
Jochen Roth voted on patch set 5 CR +1 V +1 06/14/24, 13:25
-
Christian Kuhn commented on patch set 5 CR +2 V +2 06/14/24, 13:35
CI is green but no vote received. -
Christian Kuhn merged patch set 6 06/14/24, 13:35