Review main Merged

84708[TASK] Avoid indexed_search debugMode & index_debug

Christian Kuhn CR +2 V +2 Normal +4 −80 updated 06/14/24, 13:35

Commit message

We've had quite a few patches to streamline and clean
up indexed_search. This patch continues these efforts.

ext_conf_template.txt debugMode from 2014:
"Only for debugging since it slows down the system and
fills the database with crap."

This is still true: Enabled debugMode fills the
database with crap.

Looking closer at the functionality, we decided to
remove it without substitution:

* Persisting debug info triggered by FE scaling with the
  number of pages or worse isn't a great idea in the
  first place.
* This debug is more log-like, we do have rotation
  handling of large logs, but of course not for something
  like this debug table.
* It's risky enabling debugMode in dev and then accidentally
  deploying this to live, potentially ending up with a
  *huge* table.
* The debug data is actually not really helpful: It basically
  logs the ext config (boring and redundant) over and over
  again, plus some close to never changing info which file
  parsers are registered, plus FE content. Important parts
  derived from this FE content is already stored in index_phash,
  and the content *itself* is cut at 1000 chars, which
  isn't helpful either. There is actually nothing fancy in
  this table that couldn't be discovered with true debugging
  tools by developers.

The patch removes the ext_conf_template.txt debugMode setting,
plus the table. This is not considered breaking since it's
internal and not extendable ext:indexed_search functionality.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Andreas Kienast +1

Issues 1

Files 12

Review log 1619

  1. Christian Kuhn uploaded patch set 1 06/13/24, 20:41

  2. core-ci voted on patch set 1 V +1 06/13/24, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59542

  3. Christian Kuhn updated the commit message in patch set 2 V +1 06/14/24, 09:59

  4. Andreas Kienast updated the commit message in patch set 3 06/14/24, 10:02

  5. core-ci voted on patch set 2 V +1 06/14/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59590

  6. Andreas Kienast voted on patch set 3 CR +1 V +1 06/14/24, 10:06

  7. core-ci voted on patch set 3 V +1 06/14/24, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59592

  8. Georg Ringer commented on patch set 3 06/14/24, 11:07

    should we add the setting to SilentConfigurationUpgradeService?
  9. Christian Kuhn commented on patch set 3 06/14/24, 11:15

    Reply

    oehm. good point, we have no example for a detail in EXTENSIONS, though. afaik, we just rely on 'will be removed on next extension settings safe automatically' I'd say it does not harm much to keep that setting for existing instances and just ignore it. fine with you?
  10. Jochen Roth voted on patch set 3 CR +1 V +1 06/14/24, 12:31

  11. Christian Kuhn uploaded patch set 4 CR +1 V +1 06/14/24, 13:13

  12. Christian Kuhn commented on patch set 4 06/14/24, 13:13

    Reply

    ok, added.
  13. Jochen Roth voted on patch set 4 CR +1 V +1 06/14/24, 13:14

  14. Andreas Kienast voted on patch set 4 CR +1 V +1 06/14/24, 13:18

  15. Christian Kuhn uploaded patch set 5 CR +1 V +1 06/14/24, 13:23

  16. Andreas Kienast voted on patch set 5 CR +1 V +1 06/14/24, 13:23

  17. Jochen Roth voted on patch set 5 CR +1 V +1 06/14/24, 13:25

  18. Christian Kuhn commented on patch set 5 CR +2 V +2 06/14/24, 13:35

    CI is green but no vote received.
  19. Christian Kuhn merged patch set 6 06/14/24, 13:35