Review main Merged

84710[TASK] Don't show dropzone when using Upload button

Andreas Nedbal CR +2 V +2 Easy +1 −2 updated 08/06/24, 11:38

Commit message

Since the file upload button shows the dialog directly it is
not necessary to also show the dropzone behind it. This also
solves the problem of the dropzone staying visible when a user
decides to not upload any file and cancelling the file dialog.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Sebastian Klein +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Riccardo De Contardi +1
    • Sebastian Klein +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Andreas Nedbal uploaded patch set 1 06/14/24, 09:32

  2. core-ci voted on patch set 1 V -1 06/14/24, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59584

  3. Andreas Nedbal uploaded patch set 2 V -1 06/14/24, 10:01

  4. core-ci voted on patch set 2 V +1 06/14/24, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59591

  5. Riccardo De Contardi commented on patch set 2 V +1 08/01/24, 16:31

    Tested on latest main. Question: the patch removes the "dropzone" when the upload file dialog popup is direcly shown, right? Then,when the "dropzone" would be shown? Are there other modules that use it?
  6. Georg Ringer voted on patch set 2 CR +1 V +1 08/01/24, 18:17

  7. Georg Ringer commented on patch set 2 08/01/24, 18:17

    Reply

    the dropzone is shown if you just start dragging a file to the right module
  8. Sebastian Klein voted on patch set 2 CR +1 V +1 08/01/24, 18:47

  9. Riccardo De Contardi commented on patch set 2 08/01/24, 18:49

    Reply

    I see it. you just have to drag something on the file list itself. IMHO there is a UX problem here, because the feature is totally hidden :) If must already know that it's there. I think that an explanation text could be added. I'll discuss it as a UX topic. Thank you!
  10. Christian Kuhn voted on patch set 2 CR +2 V +2 08/06/24, 11:23

  11. Christian Kuhn merged patch set 3 08/06/24, 11:38