Review main Merged

84711[BUGFIX] Make columnsOnly table-aware

Oli Bartsch CR +2 V +2 Hard +268 −51 updated 06/14/24, 16:03

Commit message

Defining columnsOnly, which is used by the
EditDocumentController to instruct the FormEngine
to only render a subset of available fields
for records is now table aware.

This allows to render records from different
tables in the same request, while respecting
the fields to be rendered on a per-table basis.

The "columnsOnly" parameter therefore now
requires the fields as array under the
corresponding table name:

&columnsOnly[pages][0]=title

A backwards-compatibility layer is in place,
migrating the previous syntax to the new one
by adding the configured fields for the
tables from the edit configuration.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 68

  1. Oli Bartsch uploaded patch set 1 06/14/24, 09:44

  2. core-ci voted on patch set 1 V -1 06/14/24, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59585

  3. Oli Bartsch uploaded patch set 2 V -1 06/14/24, 09:51

  4. core-ci voted on patch set 2 V +1 06/14/24, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59588

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 06/14/24, 13:17

  6. Jochen Roth voted on patch set 2 CR +1 V +1 06/14/24, 13:36

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 06/14/24, 16:03

  8. Oli Bartsch merged patch set 3 06/14/24, 16:03