Review main Merged

84714[TASK] Streamline DefaultTcaSchema

Christian Kuhn CR +2 V +2 Expert +668 −829 updated 06/17/24, 12:37

Commit message

Have a switch/case for the main per-type
construct and avoid loops per type.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 16

Review log 68

  1. Christian Kuhn uploaded patch set 1 06/14/24, 11:02

  2. core-ci voted on patch set 1 V -1 06/14/24, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59596

  3. Christian Kuhn uploaded patch set 2 V -1 06/14/24, 13:10

  4. core-ci voted on patch set 2 V +1 06/14/24, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59604

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 06/14/24, 13:30

  6. Benni Mack voted on patch set 2 CR +1 V +1 06/14/24, 14:24

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 06/17/24, 12:37

  8. Christian Kuhn merged patch set 3 06/17/24, 12:37