Review main Merged

84716[BUGFIX] Fix ExtensionScanner ignoring all lines instead of single one

Garvin Hicking CR +2 V +2 Normal +66 −2 updated 06/17/24, 14:31

Commit message

Once the ExtensionScanner hits a '@extensionScannerIgnoreLine'
annotated code line, it internally sets a flag that is never
reset.

That causes all following lines to be ignored, not just one.

This patch will reset the property `$isCurrentLineIgnored`
to `false` again, once the annotated line has passed.

Tests are adapted to verify this behaviour.

Due to the behavioral change it is possible that the scanner
now finds more hits in third-party scanned extensions
that previously may have been ignored.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 33

Show 13 more files

Review log 810

  1. Garvin Hicking uploaded patch set 1 06/14/24, 11:51

  2. core-ci voted on patch set 1 V -1 06/14/24, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59598

  3. core-ci voted on patch set 1 V +1 06/14/24, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59598

  4. Simon Schaufelberger commented on patch set 1 06/14/24, 14:07

    what about 11?
  5. Garvin Hicking commented on patch set 1 06/14/24, 15:21

    Reply

    Since this code is ancient it could apply to v11. Leaving this up to core mergers to decide.
  6. Christian Kuhn commented on patch set 1 06/17/24, 13:39

    Reply

    no v11 merge: not critical browser issue, not securiy related.
  7. Christian Kuhn voted on patch set 1 CR +1 V +1 06/17/24, 14:23

  8. Stefan Bürk voted on patch set 1 CR +1 V +1 06/17/24, 14:28

  9. Christian Kuhn voted on patch set 1 CR +2 V +2 06/17/24, 14:31

  10. Christian Kuhn merged patch set 2 06/17/24, 14:31