84718[BUGFIX] Fix imageManipulation allowedAspectRatios with "." notation
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1316
-
Garvin Hicking uploaded patch set 1 06/14/24, 15:05
-
core-ci voted on patch set 1 V +1 06/14/24, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59608
-
Simon Schaufelberger commented on patch set 1 06/18/24, 20:44
-
Garvin Hicking uploaded patch set 2
V +106/19/24, 09:27CGL -
Garvin Hicking commented on patch set 2 06/19/24, 09:27
Ratio.php:58ReplyTrue, thank you! PHPStorm automatically inserted it for me and I didn't pay attention. Removed it. The whole file needs cleaning up in that regard, but beyond scope of this PR. -
core-ci voted on patch set 2 V +1 06/19/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59845
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 06/19/24, 10:27
-
Benni Mack commented on patch set 2 06/21/24, 09:50
Ratio.php:56should we keep this method internal? -
Garvin Hicking commented on patch set 2 06/21/24, 12:23
Ratio.php:56Replygood catch, yes - should be refactored out as a BC in v14 so better not anyone use it til then. Can only fix this next week, if anyone wants to push over it feel free! -
Benni Mack commented on patch set 3
CR +1V +106/21/24, 12:23Published edit on patch set 2. -
Benni Mack commented on patch set 3 CR +1 06/21/24, 12:23
Ratio.php:56ReplyDone -
core-ci voted on patch set 3 V +1 06/21/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60013
-
Simon Schaufelberger voted on patch set 3 CR +1 06/21/24, 12:34
-
Jasmina Ließmann voted on patch set 3 V +1 06/21/24, 13:20
-
Christian Kuhn voted on patch set 3 CR +2 V +2 06/21/24, 13:37
-
Christian Kuhn merged patch set 4 06/21/24, 13:37
Ratio.php:58