Review main Merged

84718[BUGFIX] Fix imageManipulation allowedAspectRatios with "." notation

Garvin Hicking CR +2 V +2 Easy +32 −1 updated 06/21/24, 13:37

Commit message

Internally, all allowedAspectRatios will replace a "." character
with "_" to prevent problems with Fluid variable key access.

The lead to a situation that the backend was unable to reference
the current selectedRatio, because the comparison was not
performed on the "fixed" key name.

This patch now uses a central "fix" method Ratio::prepareAspectRatioId
in both the value object preparation as well as the configuration
instantiation.

The EXT:styleguide imageManipulation element 'crop_3' has been
enhanced to utilize such an allowedAspectRatio for easier re-
production.

This workaround should be addressed as a breaking change in
TYPO3v14, a note has been added.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1316

  1. Garvin Hicking uploaded patch set 1 06/14/24, 15:05

  2. core-ci voted on patch set 1 V +1 06/14/24, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59608

  3. Simon Schaufelberger commented on patch set 1 06/18/24, 20:44

    Ratio.php:58

    those can be dropped as they don't add new meaning.
  4. Garvin Hicking uploaded patch set 2 V +1 06/19/24, 09:27

    CGL
  5. Garvin Hicking commented on patch set 2 06/19/24, 09:27

    Ratio.php:58 Reply

    True, thank you! PHPStorm automatically inserted it for me and I didn't pay attention. Removed it. The whole file needs cleaning up in that regard, but beyond scope of this PR.
  6. core-ci voted on patch set 2 V +1 06/19/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59845

  7. Simon Schaufelberger voted on patch set 2 CR +1 V +1 06/19/24, 10:27

  8. Benni Mack commented on patch set 2 06/21/24, 09:50

    Ratio.php:56

    should we keep this method internal?
  9. Garvin Hicking commented on patch set 2 06/21/24, 12:23

    Ratio.php:56 Reply

    good catch, yes - should be refactored out as a BC in v14 so better not anyone use it til then. Can only fix this next week, if anyone wants to push over it feel free!
  10. Benni Mack commented on patch set 3 CR +1 V +1 06/21/24, 12:23

    Published edit on patch set 2.
  11. Benni Mack commented on patch set 3 CR +1 06/21/24, 12:23

    Ratio.php:56 Reply

    Done
  12. core-ci voted on patch set 3 V +1 06/21/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60013

  13. Simon Schaufelberger voted on patch set 3 CR +1 06/21/24, 12:34

  14. Jasmina Ließmann voted on patch set 3 V +1 06/21/24, 13:20

  15. Christian Kuhn voted on patch set 3 CR +2 V +2 06/21/24, 13:37

  16. Christian Kuhn merged patch set 4 06/21/24, 13:37