Review main Merged

84720[FEATURE] Command to generate Fluid schema files

Simon Praetorius CR +2 V +2 Normal +159 −0 updated 06/27/24, 20:02

Commit message

The XSD schema generator, added with Fluid Standalone 2.12,
is applied to TYPO3's Fluid integration. This provides
autocompletion for supporting IDEs (like PhpStorm) by executing
the CLI command added with this patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2836

Show 711 earlier messages
  1. Simon Praetorius uploaded patch set 1 06/14/24, 17:59

  2. core-ci voted on patch set 1 V -1 06/14/24, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59614

  3. Simon Praetorius uploaded patch set 2 V -1 06/26/24, 14:57

  4. core-ci voted on patch set 2 V -1 06/26/24, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60396

  5. Simon Praetorius uploaded patch set 3 V -1 06/26/24, 15:11

  6. core-ci voted on patch set 3 V -1 06/26/24, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60398

  7. Simon Praetorius uploaded patch set 4 V -1 06/26/24, 16:36

  8. core-ci voted on patch set 4 V +1 06/26/24, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60405

  9. Simon Praetorius marked it ready for review 06/26/24, 16:42

  10. Christian Kuhn voted on patch set 4 CR +1 V +1 06/26/24, 16:48

  11. Stefan Bürk voted on patch set 4 CR -1 06/26/24, 16:57

  1. Stefan Bürk commented on patch set 4 06/26/24, 17:03

    SchemaCommand.php:87

    We need to ensure that the transient subfolder really exists, otherwise the files are not written at all (silently). At best, we do that onces before the foreach loop.
  2. Stefan Bürk commented on patch set 4 06/26/24, 17:05

    SchemaCommand.php:87 Reply

    GU::tempnam() does similar check and uses mkdir_deep() to ensure it.
  3. Simon Praetorius uploaded patch set 5 CR +1 V +1 06/27/24, 09:10

  4. Simon Praetorius commented on patch set 5 06/27/24, 09:10

    SchemaCommand.php:87 Reply

    Done
  5. core-ci voted on patch set 5 V +1 06/27/24, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60442

  6. Benni Mack commented on patch set 5 06/27/24, 09:34

    SchemaCommand.php:102

    let's use GeneralUtility::writeFile()
  7. Simon Praetorius uploaded patch set 6 V +1 06/27/24, 13:53

  8. Simon Praetorius commented on patch set 6 06/27/24, 13:53

    SchemaCommand.php:102 Reply

    Done
  9. core-ci voted on patch set 6 V +1 06/27/24, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60465

  10. Stefan Bürk voted on patch set 6 CR +1 V +1 06/27/24, 14:41

  11. Benni Mack voted on patch set 6 CR +1 V +1 06/27/24, 19:21

  12. Benni Mack voted on patch set 6 CR 0 06/27/24, 19:25

  13. Christian Kuhn uploaded patch set 7 CR +1 V +1 06/27/24, 19:33

  14. Christian Kuhn commented on patch set 7 06/27/24, 19:34

    we decided for fluid:schema:generate
  15. Christian Kuhn voted on patch set 7 CR +1 V +1 06/27/24, 19:34

  16. Benni Mack voted on patch set 7 CR +1 V +1 06/27/24, 19:35

  17. Christian Kuhn voted on patch set 7 CR 0 V 0 06/27/24, 19:36

  18. Christian Kuhn uploaded patch set 8 CR +1 V +1 06/27/24, 19:38

  19. core-ci voted on patch set 7 V +1 06/27/24, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60486

  20. Christian Kuhn voted on patch set 8 CR +1 V +1 06/27/24, 19:42

  21. core-ci voted on patch set 8 V +1 06/27/24, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60487

  22. Benni Mack voted on patch set 8 CR +1 V +1 06/27/24, 19:45

  23. Stefan Bürk voted on patch set 8 CR +1 V +1 06/27/24, 19:49

  24. Christian Kuhn voted on patch set 8 CR +2 V +2 06/27/24, 20:02

  25. Christian Kuhn merged patch set 9 06/27/24, 20:02