Review main Merged

84721[TASK] Render generator fields as hidden fields in columnsOnly mode

Oli Bartsch CR +2 V +2 Normal +107 −23 updated 06/18/24, 14:20

Commit message

When using the "columnsOnly" mode to render just
a subset of available fields of a record, while
the subset includes a field of TCA type "slug",
FormEngine needs to also render configured generator
fields. Otherwise the slug fields won't work as
expected, e.g. when recalculating.

However, since it might be confusing for an editor
to get fields rendered, which were not selected,
are those fields now rendered as hidden fields.

This is done by adding those fields to a hidden
palette while omitting duplicates and performing
sanitization.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 811

  1. Oli Bartsch uploaded patch set 1 06/14/24, 18:09

  2. core-ci voted on patch set 1 V -1 06/14/24, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59615

  3. Oli Bartsch uploaded patch set 2 V -1 06/14/24, 18:23

  4. core-ci voted on patch set 2 V +1 06/14/24, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59617

  5. Jochen Roth commented on patch set 2 06/15/24, 13:27

    ListOfFieldsContainer.php:28

    `... to render`
  6. Jochen Roth uploaded patch set 3 V +1 06/15/24, 13:28

  7. Jochen Roth commented on patch set 3 CR +1 V +1 06/15/24, 13:29

    ListOfFieldsContainer.php:28 Reply

    Done
  8. core-ci voted on patch set 3 V +1 06/15/24, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59645

  9. Benni Mack voted on patch set 3 CR +1 V +1 06/18/24, 11:23

  10. Oli Bartsch voted on patch set 3 CR +2 V +2 06/18/24, 14:20

  11. Oli Bartsch merged patch set 4 06/18/24, 14:20