Review 12.4 Merged

84722[BUGFIX] Fix backend page tree filter with special characters

Garvin Hicking CR +2 V +2 Easy +3 −2 updated 06/21/24, 12:21

Commit message

When filtering the page tree with characters that have
special meaning for a regular expression (for example,
")" or "(" or "?" and some others), the filtering would
return a "Page Tree error".

JavaScript does not have something like "preg_quote",
so this uses the escape string provided by the MDN
with fixed special characters.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1418

  1. Garvin Hicking uploaded patch set 1 06/15/24, 07:13

  2. Garvin Hicking updated the commit message in patch set 2 06/15/24, 07:13

  3. core-ci voted on patch set 1 V +1 06/15/24, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59637

  4. core-ci voted on patch set 2 V +1 06/15/24, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59638

  5. Georg Ringer voted on patch set 2 CR +1 V +1 06/17/24, 07:39

  6. Andreas Kienast commented on patch set 2 CR -1 06/18/24, 20:05

    temp -1, I want to take a closer look
  7. Andreas Kienast commented on patch set 2 06/19/24, 12:37

    main is affected as well
  8. Andreas Kienast updated the commit message in patch set 3 CR +1 V +1 06/19/24, 12:47

  9. Andreas Kienast commented on patch set 3 06/19/24, 12:48

    Reply

    Done
  10. core-ci voted on patch set 3 V +1 06/19/24, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59852

  11. Jasmina Ließmann commented on patch set 3 V -1 06/19/24, 14:24

    Works for v12. Not tested in v11. In v13, no error message appears, but the page is not displayed correctly in the page tree or the page tree is cut off. Example pages that I tested with: 1. "Test page" 1a. "Subpage XY" (as a subpage of "Test page") 2. "Foo bar(test)" 3. "Subpage (test)" - If I search for "test", pages 1, 2 and 3 are displayed. - If I search for "(test)", pages 2 and 3 are displayed. The highlighting is only applied to the word "test", not to the brackets. - If I search for "bar(test)", page 2 is displayed, but no highlighting is applied at all. - If I search for "(tes", only page 2 is displayed (without highlighting) - or, if I reload the browser and try again, only pages 1 and 2, but the page tree breaks off after these two pages (treeline continues downwards, but no further entries are displayed).
  12. Jasmina Ließmann commented on patch set 3 V +1 06/19/24, 19:27

    Reply

    Forget my comment, I didn't see that there was a separate main patch. (づ_ど)
  13. Jasmina Ließmann voted on patch set 3 CR +1 06/19/24, 19:46

  14. Garvin Hicking uploaded patch set 4 CR +1 V +1 06/21/24, 06:29

    backport regexp documentation
  15. core-ci voted on patch set 4 V +1 06/21/24, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59973

  16. Jasmina Ließmann voted on patch set 4 CR +1 V +1 06/21/24, 08:08

  17. Andreas Kienast voted on patch set 4 CR +2 V +2 06/21/24, 11:35

  18. Andreas Kienast merged patch set 5 06/21/24, 12:21