84724[TASK] Add styleguide uuid example fields
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/styleguide/Classes/Service/KauderwelschService.php2+8 −24
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeUuid.php2new+47 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGeneratorResolver.php+2 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php+27 −1
Review log 1418
-
Philipp Kuhlmay uploaded patch set 1 06/15/24, 11:38
-
core-ci voted on patch set 1 V +1 06/15/24, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59642
-
Georg Ringer voted on patch set 1 CR +1 V +1 06/15/24, 18:09
-
Philipp Kuhlmay updated the commit message in patch set 2
CR +1V +106/17/24, 11:44 -
core-ci voted on patch set 2 V +1 06/17/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59724
-
Philipp Kuhlmay uploaded patch set 3
V +106/17/24, 15:20 -
core-ci voted on patch set 3 V +1 06/17/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59745
-
Garvin Hicking voted on patch set 3 CR +1 V +1 06/17/24, 16:00
-
Georg Ringer commented on patch set 3 06/17/24, 19:06
-
Christian Kuhn commented on patch set 3 CR -1 06/18/24, 11:25
KauderwelschService.php:158i'd tend to actually return a "stable" hardcoded string here, just as all other members of the service do. also: do we need two different methods for v4 and v7? -
Christian Kuhn commented on patch set 3 06/18/24, 11:26
will try to update -
Christian Kuhn uploaded patch set 4
CR +1V +106/18/24, 11:43 -
Christian Kuhn commented on patch set 4 06/18/24, 11:44
Reply
DoneKauderwelschService.php:158ReplyDoneTypeUuid.php:48ReplyDone -
Christian Kuhn voted on patch set 4 CR +1 V +1 06/18/24, 11:44
-
Garvin Hicking voted on patch set 4 CR +1 V +1 06/18/24, 11:45
-
core-ci voted on patch set 4 V +1 06/18/24, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59794
-
Georg Ringer voted on patch set 4 CR +2 V +2 06/18/24, 18:43
-
Georg Ringer merged patch set 5 06/18/24, 18:43
TypeUuid.php:48