Review main Merged

84724[TASK] Add styleguide uuid example fields

Philipp Kuhlmay CR +2 V +2 Normal +84 −25 updated 06/18/24, 18:43

Commit message

This patch provides some examples for the type=uuid
in ext:styleguides 'basic' table including a generator
for this type.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1418

  1. Philipp Kuhlmay uploaded patch set 1 06/15/24, 11:38

  2. core-ci voted on patch set 1 V +1 06/15/24, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59642

  3. Georg Ringer voted on patch set 1 CR +1 V +1 06/15/24, 18:09

  4. Philipp Kuhlmay updated the commit message in patch set 2 CR +1 V +1 06/17/24, 11:44

  5. core-ci voted on patch set 2 V +1 06/17/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59724

  6. Philipp Kuhlmay uploaded patch set 3 V +1 06/17/24, 15:20

  7. core-ci voted on patch set 3 V +1 06/17/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59745

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 06/17/24, 16:00

  9. Georg Ringer commented on patch set 3 06/17/24, 19:06

    TypeUuid.php:48

    the type cast shouldn't be needed
  10. Christian Kuhn commented on patch set 3 CR -1 06/18/24, 11:25

    KauderwelschService.php:158

    i'd tend to actually return a "stable" hardcoded string here, just as all other members of the service do. also: do we need two different methods for v4 and v7?
  11. Christian Kuhn commented on patch set 3 06/18/24, 11:26

    will try to update
  12. Christian Kuhn uploaded patch set 4 CR +1 V +1 06/18/24, 11:43

  13. Christian Kuhn commented on patch set 4 06/18/24, 11:44

    Reply

    Done

    KauderwelschService.php:158 Reply

    Done

    TypeUuid.php:48 Reply

    Done
  14. Christian Kuhn voted on patch set 4 CR +1 V +1 06/18/24, 11:44

  15. Garvin Hicking voted on patch set 4 CR +1 V +1 06/18/24, 11:45

  16. core-ci voted on patch set 4 V +1 06/18/24, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59794

  17. Georg Ringer voted on patch set 4 CR +2 V +2 06/18/24, 18:43

  18. Georg Ringer merged patch set 5 06/18/24, 18:43