Review main Merged

84727[DOCS] Handle FormDefinitions separately

Stefan Froemken CR +2 V +2 Hard +354 −329 updated 08/02/24, 08:16

Commit message

Move documentation of FormDefinition into its own
section as FormDefinition is not part of form elements.
Internally FormDefinition will be handled completely different.

Add section to FormDefinition how to work with
`fluidAdditionalAttributes` as part of `renderingOptions`
instead of `properties`

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 110

Show 90 more files

Review log 1420

  1. Stefan Froemken uploaded patch set 1 06/16/24, 11:22

  2. core-ci voted on patch set 1 V +1 06/16/24, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59677

  3. Stefan Froemken uploaded patch set 2 V +1 06/16/24, 11:39

  4. core-ci voted on patch set 2 V +1 06/16/24, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59678

  5. Lina Wolf commented on patch set 2 06/17/24, 06:19

    Thanks for taking care of this, I will have a detailed look later
  6. Lina Wolf commented on patch set 2 06/17/24, 06:21

    I am not sure about the 11.5 backport. I would probably opt for merging this only for 12.4 and main as 11.5 is not rendering without warnings in the new rendering, backporting proofs to be complicated and 11.5 is almost out of support anyway.
  7. Christian Kuhn commented on patch set 2 06/17/24, 13:42

    Reply

    no v11 please. and v12 only if the backport is 'reasonable' simple.
  8. Stefan Froemken updated the commit message in patch set 3 V +1 06/17/24, 17:58

  9. core-ci voted on patch set 3 V +1 06/17/24, 18:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59750

  10. Lina Wolf commented on patch set 3 06/22/24, 05:55

    Reply

    Acknowledged
  11. Stefan Froemken rebased onto patch set 4 V +1 06/22/24, 06:15

  12. Stefan Froemken uploaded patch set 5 06/22/24, 06:18

  13. Stefan Froemken commented on patch set 5 06/22/24, 06:20

    rebased. Hopefully I have done it the right way
  14. core-ci voted on patch set 4 V +1 06/22/24, 06:21 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 5 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60063

  15. core-ci voted on patch set 5 V +1 06/22/24, 06:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60064

  16. Lina Wolf uploaded patch set 6 V +1 06/22/24, 09:52

  17. core-ci voted on patch set 6 V +1 06/22/24, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60069

  18. Georg Ringer voted on patch set 6 CR +1 V +1 06/23/24, 13:20

  19. Lina Wolf voted on patch set 6 CR +2 V +2 08/02/24, 08:15

  20. Lina Wolf merged patch set 7 08/02/24, 08:16