Review 12.4 Merged

84733[BUGFIX] Fix ExtensionScanner ignoring all lines instead of single one

Christian Kuhn CR +2 V +2 Normal +66 −2 updated 06/17/24, 14:32

Commit message

Once the ExtensionScanner hits a '@extensionScannerIgnoreLine'
annotated code line, it internally sets a flag that is never
reset.

That causes all following lines to be ignored, not just one.

This patch will reset the property `$isCurrentLineIgnored`
to `false` again, once the annotated line has passed.

Tests are adapted to verify this behaviour.

Due to the behavioral change it is possible that the scanner
now finds more hits in third-party scanned extensions
that previously may have been ignored.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 33

Show 13 more files

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/17/24, 14:25

  2. core-ci voted on patch set 1 V +1 06/17/24, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59736

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/17/24, 14:31

  4. Christian Kuhn merged patch set 2 06/17/24, 14:32