Review main Merged

84734[TASK] Move toolbar language keys to corresponding extensions

Jasmina Ließmann CR +2 V +2 Hard +203 −222 updated 06/24/24, 12:01

Commit message

Language keys used in toolbar context are now in their corresponding
extensions. The following language keys were unused and have been
removed:
- toolbarItems.shortcut
- toolbarItems.shortcuts
- toolbarItems.shortcutsGroup
- toolbarItems.shortcutsEdit
- toolbarItems.shortcutsDelete
- toolbarItems.bookmark
- toolbarItems.bookmarksGroup
- toolbarItems.collapsePageTree
- systemInformation.header

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1624

  1. Jasmina Ließmann uploaded patch set 1 06/17/24, 14:31

  2. core-ci voted on patch set 1 V +1 06/17/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59737

  3. Georg Ringer commented on patch set 1 06/17/24, 19:10

    I don't know if we should start that without a big picture - also what is public API and what not. all changes like that require work for all translators and I don't know the real benefit besides some moving around. for other extension authors this makes it now also harder because they need to support both places
  4. Georg Ringer voted on patch set 1 CR -1 06/17/24, 19:10

  5. Christian Kuhn commented on patch set 1 06/18/24, 07:04

    Reply

    We have no API definition for labels at all, Georg. Even if we'd have, I'd argue that just a few very generic labels should be, and those should be placed in a central position everybody knows. Please go ahead and discuss, find consensus and establish something like this in the merger team. I'll appreciate this. Last time I talked with Josef Glatz, he didn't perceive it as a huge issues when core moves labels to better positions, or give them better names, but appreciated these efforts since it simplifies translators works. In this case, toolbar related labels are moved from ext:core to ext:backend and a few other extensions. This is good: The toolbar infrastructure belongs to ext:backend, and ext:backend defines most. Labels should be defined by the extension that adds a toolbar item. Having them in ext:core is not good, positioning them within the correct extension is better and separates things properly to for instance one day make ext:backend unloadable.
  6. Jasmina Ließmann uploaded patch set 2 CR -1 V +1 06/21/24, 12:42

  7. core-ci voted on patch set 2 V +1 06/21/24, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60015

  8. Jasmina Ließmann uploaded patch set 3 V +1 06/21/24, 14:07

  9. core-ci voted on patch set 3 V +1 06/21/24, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60030

  10. Jasmina Ließmann uploaded patch set 4 V +1 06/21/24, 14:16

  11. core-ci voted on patch set 4 V +1 06/21/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60032

  12. Jasmina Ließmann uploaded patch set 5 V +1 06/21/24, 14:44

  13. Jasmina Ließmann updated the commit message in patch set 6 06/21/24, 14:44

  14. core-ci voted on patch set 5 V +1 06/21/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60034

  15. core-ci voted on patch set 6 V +1 06/21/24, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60035

  16. Jasmina Ließmann updated the commit message in patch set 7 V +1 06/21/24, 15:02

  17. Christian Kuhn commented on patch set 7 CR +1 V +1 06/21/24, 15:07

    Reply

    i hope it's ok to resolve here: this patch is about the specific toolbar labels and those really should be relocated into the according extensions.
  18. core-ci voted on patch set 7 V +1 06/21/24, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60036

  19. Christian Kuhn voted on patch set 7 CR 0 V 0 06/21/24, 15:07

  20. Jasmina Ließmann uploaded patch set 8 V +1 06/21/24, 15:14

  21. core-ci voted on patch set 8 V +1 06/21/24, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60037

  22. Christian Kuhn voted on patch set 8 CR +1 V +1 06/24/24, 11:53

  23. Georg Ringer voted on patch set 8 CR +2 V +2 06/24/24, 12:01

  24. Georg Ringer merged patch set 9 06/24/24, 12:01