Review main Merged

84738[TASK] Improve UX and accessibility of toolbar items

Jasmina Ließmann CR +2 V +2 Hard +185 −136 updated 06/20/24, 14:04

Commit message

Several minor adjustments have been made to the toolbar items to
improve the UX and accessibility.

This includes, among other things, the following:
* Setting a correct heading hierarchy and adding some role attributes.
* When a bookmark has been assigned to a group, the section with the
  remaining ungrouped bookmarks now displays a corresponding heading.
* The form for editing bookmarks now has form labels and static input
  labels have been replaced.
* When no documents are currently open or have been used recently, the
  section headings are now displayed with corresponding info texts.
* Links to perform actions are now displayed in button style.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 2842

Show 1117 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 06/17/24, 15:01

  2. core-ci voted on patch set 1 V -1 06/17/24, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59744

  3. Jasmina Ließmann uploaded patch set 2 V -1 06/18/24, 08:55

  4. core-ci voted on patch set 2 V +1 06/18/24, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59785

  5. Jasmina Ließmann uploaded patch set 3 V +1 06/18/24, 09:42

  6. core-ci voted on patch set 3 V +1 06/18/24, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59790

  7. Jasmina Ließmann updated the commit message in patch set 4 V +1 06/18/24, 09:52

  8. core-ci voted on patch set 4 V +1 06/18/24, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59792

  9. Christian Kuhn voted on patch set 4 CR +1 V +1 06/18/24, 10:47

  10. Ayke Halder commented on patch set 4 06/18/24, 13:26

    All elements that behave like a button need `role="button"` if they are not HTMl-tag `<button>`. Otherwise screenreaders take them as link and e.g. for `<a href="#" class"btn">TITLE</a>` might read out something like: "Link <TITLE> already visited"

    ShortcutToolbarItemDropDown.html:41

    This should be `role="button"`

    ShortcutToolbarItemDropDown.html:46

    This should be `role="button"`

    DropDown.html:28

    This should be `role="button"`

    DropDown.html:37

    This should be `role="button"`

    DropDown.html:28

    This should be `role="button"`
  11. Jasmina Ließmann uploaded patch set 5 CR +1 V +1 06/19/24, 15:17

  12. Jasmina Ließmann updated the commit message in patch set 6 06/19/24, 15:19

  13. core-ci voted on patch set 5 V -1 06/19/24, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59860

  14. core-ci voted on patch set 6 V -1 06/19/24, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59861

  15. Jasmina Ließmann uploaded patch set 7 V -1 06/19/24, 20:22

  16. Jasmina Ließmann commented on patch set 7 06/19/24, 20:23

    ShortcutToolbarItemDropDown.html:41 Reply

    Done

    ShortcutToolbarItemDropDown.html:46 Reply

    Done

    DropDown.html:28 Reply

    Done

    DropDown.html:37 Reply

    Done

    DropDown.html:28 Reply

    Not relevant anymore.
  17. Jasmina Ließmann uploaded patch set 8 06/19/24, 20:25

  1. core-ci voted on patch set 7 V -1 06/19/24, 20:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59865

  2. core-ci voted on patch set 8 V +1 06/19/24, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59867

  3. Jasmina Ließmann uploaded patch set 9 V +1 06/19/24, 20:34

  4. core-ci voted on patch set 9 V +1 06/19/24, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59869

  5. Jasmina Ließmann uploaded patch set 10 V +1 06/19/24, 21:13

  6. Jasmina Ließmann uploaded patch set 11 06/19/24, 21:18

  7. core-ci voted on patch set 10 V +1 06/19/24, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59874

  8. core-ci voted on patch set 11 V +1 06/19/24, 21:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59875

  9. Jasmina Ließmann uploaded patch set 12 V +1 06/19/24, 21:30

  10. core-ci voted on patch set 12 V +1 06/19/24, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59876

  11. Ayke Halder commented on patch set 11 06/19/24, 21:35

    HelpToolbarItemDropDown.html:2

    `<p class="h3 dropdown-headline" …>…</p>` has no heading hierarchy - this is visual styling only. Maybe use a real heading here? `<h3 class="dropdown-headline" …>…</h3>`

    ShortcutToolbarItemDropDown.html:1

    Maybe use a real heading `<h3 class="dropdown-headline" …>…</h3>` here?

    ShortcutToolbarItemDropDown.html:11

    ### Group/Separator - option A: Looks like we have a `group` here. Maybe add a container with `role="group"` instead of using separators. See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/group_role#examples ```html <div role="menu"> <ul role="group"> <li role="menuitem">Inbox</li> <li role="menuitem">Archive</li> <li role="menuitem">Trash</li> </ul> <ul role="group"> <li role="menuitem">Custom Folder 1</li> <li role="menuitem">Custom Folder 2</li> <li role="menuitem">Custom Folder 3</li> </ul> <ul role="group"> <li role="menuitem">New Folder</li> </ul> </div> ```

    ShortcutToolbarItemDropDown.html:13

    ### Group/Separator - option B: `<hr>` looks usable for screenreaders - no need to add `aria-hidden="true"`. See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/separator_role

    ShortcutToolbarItemDropDown.html:17

    ### Group/Separator - option C: Or keep the `<hr />` above as solely visual representation via `aria-hidden="true"`. Then make this the real separator by adding `role="separator"`: See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/separator_role#all_descendants_are_presentational --- Maybe use a real heading <h4 class="dropdown-headline" …>…</h4> here?

    ShortcutToolbarItemDropDown.html:20

    Maybe use a real heading <h4 class="dropdown-headline" …>…</h4> here?

    ShortcutToolbarItemDropDown.html:41

    Does this also work with `<button type="button" class="…"><span class="visually-hidden">[TITLE]</span>[ICON]</button>` instead of `<a href="#" role="button" title="[TITLE]" class="…">[ICON]</a>` See * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button * https://getbootstrap.com/docs/5.3/getting-started/accessibility/#visually-hidden-content

    ShortcutToolbarItemEditForm.html:1

    Maybe use a real heading <h3 class="dropdown-headline" …>…</h3> here?

    UserToolbarItemDropDown.html:38

    Maybe use a real heading <h4 class="dropdown-headline" …>…</h4> here?

    DropDown.html:10

    Maybe use a real heading <h4 class="dropdown-headline" …>…</h4> here?

    DropDown.html:28

    Check if it works with real `<button>`.

    DropDown.html:41

    Check if it works with real `<button>`.

    DropDown.html:58

    Maybe use a real heading <h4 class="dropdown-headline" …>…</h4> here?

    DropDown.html:3

    Maybe use a real heading <h3 class="dropdown-headline" …>…</h3> here?
  12. Jasmina Ließmann uploaded patch set 13 V +1 06/19/24, 21:51

  13. Jasmina Ließmann commented on patch set 13 06/19/24, 21:56

    HelpToolbarItemDropDown.html:2 Reply

    I have already consulted with the Accessibility team and this will not be converted to a headline.

    ShortcutToolbarItemDropDown.html:1 Reply

    I have already consulted with the Accessibility team and this will not be converted to a headline.

    ShortcutToolbarItemDropDown.html:20 Reply

    I have already consulted with the Accessibility team and this will not be converted to a headline.

    ShortcutToolbarItemEditForm.html:1 Reply

    I have already consulted with the Accessibility team and this will not be converted to a headline.

    UserToolbarItemDropDown.html:38 Reply

    I have already consulted with the Accessibility team and this will not be converted to a headline.

    DropDown.html:10 Reply

    I have already consulted with the Accessibility team and this will not be converted to a headline.

    DropDown.html:58 Reply

    I have already consulted with the Accessibility team and this will not be converted to a headline.

    DropDown.html:3 Reply

    I have already consulted with the Accessibility team and this will not be converted to a headline.
  14. core-ci voted on patch set 13 V +1 06/19/24, 21:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59878

  15. Jasmina Ließmann commented on patch set 13 06/19/24, 21:59

    ShortcutToolbarItemDropDown.html:41 Reply

    The conversion from link to button is more complex and can be addressed in a later patch.

    DropDown.html:28 Reply

    The conversion from link to button is more complex and can be addressed in a later patch.

    DropDown.html:41 Reply

    The conversion from link to button is more complex and can be addressed in a later patch.
  16. Jasmina Ließmann commented on patch set 13 06/19/24, 21:59

    DropDown.html:28 Reply

    Resolved.
  17. Jasmina Ließmann commented on patch set 13 06/19/24, 22:10

    ShortcutToolbarItemDropDown.html:11 Reply

    Not sure if a group is really more appropriate in this case. The markup will remain as it was before for this patch. A change may be made with a later patch.
  18. Jasmina Ließmann commented on patch set 13 06/20/24, 10:59

    ShortcutToolbarItemDropDown.html:13 Reply

    In this case, the horizontal lines are more decorative and should remain hidden from screen readers.

    ShortcutToolbarItemDropDown.html:17 Reply

    See answer above.
  19. Jasmina Ließmann uploaded patch set 14 V +1 06/20/24, 11:09

  20. core-ci voted on patch set 14 V +1 06/20/24, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59907

  21. Christian Kuhn voted on patch set 14 CR +1 V +1 06/20/24, 13:40

  22. Garvin Hicking voted on patch set 14 CR +1 V +1 06/20/24, 13:54

  23. Jasmina Ließmann voted on patch set 14 CR +2 V +2 06/20/24, 13:55

  24. Jasmina Ließmann merged patch set 15 06/20/24, 13:55

  25. Ayke Halder commented on patch set 14 06/20/24, 14:04

    UserToolbarItemDropDown.html:65 Unresolved

    Add `role="button"`

    UserToolbarItemDropDown.html:73 Unresolved

    Add `role="button"`