84738[TASK] Improve UX and accessibility of toolbar items
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/HelpToolbarItemDropDown.html2+0 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemDropDown.html16+14 −3
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ShortcutToolbarItemEditForm.html2+14 −9
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/UserToolbarItemDropDown.html4+14 −24
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+22 −1
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf+0 −6
- typo3/sysext/core/Tests/Acceptance/Application/Workspace/WorkspaceModuleCest.php+2 −2
- typo3/sysext/opendocs/Resources/Private/Language/locallang.xlf+11 −8
- typo3/sysext/opendocs/Resources/Private/Templates/ToolbarItems/DropDown.html13+70 −57
- typo3/sysext/workspaces/Resources/Private/Templates/ToolbarItems/DropDown.html4+38 −25
Review log 2842
Show 1117 earlier messages
-
Jasmina Ließmann uploaded patch set 1 06/17/24, 15:01
-
core-ci voted on patch set 1 V -1 06/17/24, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59744
-
Jasmina Ließmann uploaded patch set 2
V -106/18/24, 08:55 -
core-ci voted on patch set 2 V +1 06/18/24, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59785
-
Jasmina Ließmann uploaded patch set 3
V +106/18/24, 09:42 -
core-ci voted on patch set 3 V +1 06/18/24, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59790
-
Jasmina Ließmann updated the commit message in patch set 4
V +106/18/24, 09:52 -
core-ci voted on patch set 4 V +1 06/18/24, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59792
-
Christian Kuhn voted on patch set 4 CR +1 V +1 06/18/24, 10:47
-
Ayke Halder commented on patch set 4 06/18/24, 13:26
All elements that behave like a button need `role="button"` if they are not HTMl-tag `<button>`. Otherwise screenreaders take them as link and e.g. for `<a href="#" class"btn">TITLE</a>` might read out something like: "Link <TITLE> already visited"ShortcutToolbarItemDropDown.html:41This should be `role="button"`ShortcutToolbarItemDropDown.html:46This should be `role="button"`DropDown.html:28This should be `role="button"`DropDown.html:37This should be `role="button"`DropDown.html:28This should be `role="button"` -
Jasmina Ließmann uploaded patch set 5
CR +1V +106/19/24, 15:17 -
Jasmina Ließmann updated the commit message in patch set 6 06/19/24, 15:19
-
core-ci voted on patch set 5 V -1 06/19/24, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59860
-
core-ci voted on patch set 6 V -1 06/19/24, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59861
-
Jasmina Ließmann uploaded patch set 7
V -106/19/24, 20:22 -
Jasmina Ließmann commented on patch set 7 06/19/24, 20:23
ShortcutToolbarItemDropDown.html:41ReplyDoneShortcutToolbarItemDropDown.html:46ReplyDoneDropDown.html:28ReplyDoneDropDown.html:37ReplyDoneDropDown.html:28ReplyNot relevant anymore. -
Jasmina Ließmann uploaded patch set 8 06/19/24, 20:25
-
core-ci voted on patch set 7 V -1 06/19/24, 20:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59865
-
core-ci voted on patch set 8 V +1 06/19/24, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59867
-
Jasmina Ließmann uploaded patch set 9
V +106/19/24, 20:34 -
core-ci voted on patch set 9 V +1 06/19/24, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59869
-
Jasmina Ließmann uploaded patch set 10
V +106/19/24, 21:13 -
Jasmina Ließmann uploaded patch set 11 06/19/24, 21:18
-
core-ci voted on patch set 10 V +1 06/19/24, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59874
-
core-ci voted on patch set 11 V +1 06/19/24, 21:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59875
-
Jasmina Ließmann uploaded patch set 12
V +106/19/24, 21:30 -
core-ci voted on patch set 12 V +1 06/19/24, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59876
-
Ayke Halder commented on patch set 11 06/19/24, 21:35
HelpToolbarItemDropDown.html:2`<p class="h3 dropdown-headline" …>…</p>` has no heading hierarchy - this is visual styling only. Maybe use a real heading here? `<h3 class="dropdown-headline" …>…</h3>`ShortcutToolbarItemDropDown.html:1Maybe use a real heading `<h3 class="dropdown-headline" …>…</h3>` here?ShortcutToolbarItemDropDown.html:11### Group/Separator - option A: Looks like we have a `group` here. Maybe add a container with `role="group"` instead of using separators. See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/group_role#examples ```html <div role="menu"> <ul role="group"> <li role="menuitem">Inbox</li> <li role="menuitem">Archive</li> <li role="menuitem">Trash</li> </ul> <ul role="group"> <li role="menuitem">Custom Folder 1</li> <li role="menuitem">Custom Folder 2</li> <li role="menuitem">Custom Folder 3</li> </ul> <ul role="group"> <li role="menuitem">New Folder</li> </ul> </div> ```ShortcutToolbarItemDropDown.html:13### Group/Separator - option B: `<hr>` looks usable for screenreaders - no need to add `aria-hidden="true"`. See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/separator_roleShortcutToolbarItemDropDown.html:17### Group/Separator - option C: Or keep the `<hr />` above as solely visual representation via `aria-hidden="true"`. Then make this the real separator by adding `role="separator"`: See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/separator_role#all_descendants_are_presentational --- Maybe use a real heading <h4 class="dropdown-headline" …>…</h4> here?ShortcutToolbarItemDropDown.html:20Maybe use a real heading <h4 class="dropdown-headline" …>…</h4> here?ShortcutToolbarItemDropDown.html:41Does this also work with `<button type="button" class="…"><span class="visually-hidden">[TITLE]</span>[ICON]</button>` instead of `<a href="#" role="button" title="[TITLE]" class="…">[ICON]</a>` See * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button * https://getbootstrap.com/docs/5.3/getting-started/accessibility/#visually-hidden-contentShortcutToolbarItemEditForm.html:1Maybe use a real heading <h3 class="dropdown-headline" …>…</h3> here?UserToolbarItemDropDown.html:38Maybe use a real heading <h4 class="dropdown-headline" …>…</h4> here?DropDown.html:10Maybe use a real heading <h4 class="dropdown-headline" …>…</h4> here?DropDown.html:28Check if it works with real `<button>`.DropDown.html:41Check if it works with real `<button>`.DropDown.html:58Maybe use a real heading <h4 class="dropdown-headline" …>…</h4> here?DropDown.html:3Maybe use a real heading <h3 class="dropdown-headline" …>…</h3> here? -
Jasmina Ließmann uploaded patch set 13
V +106/19/24, 21:51 -
Jasmina Ließmann commented on patch set 13 06/19/24, 21:56
HelpToolbarItemDropDown.html:2ReplyI have already consulted with the Accessibility team and this will not be converted to a headline.ShortcutToolbarItemDropDown.html:1ReplyI have already consulted with the Accessibility team and this will not be converted to a headline.ShortcutToolbarItemDropDown.html:20ReplyI have already consulted with the Accessibility team and this will not be converted to a headline.ShortcutToolbarItemEditForm.html:1ReplyI have already consulted with the Accessibility team and this will not be converted to a headline.UserToolbarItemDropDown.html:38ReplyI have already consulted with the Accessibility team and this will not be converted to a headline.DropDown.html:10ReplyI have already consulted with the Accessibility team and this will not be converted to a headline.DropDown.html:58ReplyI have already consulted with the Accessibility team and this will not be converted to a headline.DropDown.html:3ReplyI have already consulted with the Accessibility team and this will not be converted to a headline. -
core-ci voted on patch set 13 V +1 06/19/24, 21:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59878
-
Jasmina Ließmann commented on patch set 13 06/19/24, 21:59
ShortcutToolbarItemDropDown.html:41ReplyThe conversion from link to button is more complex and can be addressed in a later patch.DropDown.html:28ReplyThe conversion from link to button is more complex and can be addressed in a later patch.DropDown.html:41ReplyThe conversion from link to button is more complex and can be addressed in a later patch. -
Jasmina Ließmann commented on patch set 13 06/19/24, 21:59
DropDown.html:28ReplyResolved. -
Jasmina Ließmann commented on patch set 13 06/19/24, 22:10
ShortcutToolbarItemDropDown.html:11ReplyNot sure if a group is really more appropriate in this case. The markup will remain as it was before for this patch. A change may be made with a later patch. -
Jasmina Ließmann commented on patch set 13 06/20/24, 10:59
ShortcutToolbarItemDropDown.html:13ReplyIn this case, the horizontal lines are more decorative and should remain hidden from screen readers.ShortcutToolbarItemDropDown.html:17ReplySee answer above. -
Jasmina Ließmann uploaded patch set 14
V +106/20/24, 11:09 -
core-ci voted on patch set 14 V +1 06/20/24, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59907
-
Christian Kuhn voted on patch set 14 CR +1 V +1 06/20/24, 13:40
-
Garvin Hicking voted on patch set 14 CR +1 V +1 06/20/24, 13:54
-
Jasmina Ließmann voted on patch set 14 CR +2 V +2 06/20/24, 13:55
-
Jasmina Ließmann merged patch set 15 06/20/24, 13:55
-
Ayke Halder commented on patch set 14 06/20/24, 14:04
UserToolbarItemDropDown.html:65UnresolvedAdd `role="button"`UserToolbarItemDropDown.html:73UnresolvedAdd `role="button"`