Review main Abandoned

84739[FEATURE] Add different code examples for EXT:styleguide

Philipp Kuhlmay CR 0 V 0 Easy +38 −2 updated 04/13/25, 12:05

Commit message

This is a first POC for adding multiple code examples for EXT:styleguide.
At the moment, there is only one example (for fluid) for each element. This adds some tabs with which you can select between (for example) fluid and lit JS examples.
For the future it could be possible to add some more tabs and therefore some more examples, like plain JS or PHP.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 812

  1. Philipp Kuhlmay uploaded patch set 1 06/17/24, 15:31

  2. core-ci voted on patch set 1 V +1 06/17/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59746

  3. Garvin Hicking commented on patch set 1 06/17/24, 15:38

    This is a cool idea and would be less cluttered. I wonder though if markup like this (accordions with labels and heads) might be put in a lit element instead, so that all the boilerplate HTML doesn't need repeating? (First I thought about a BE ViewHelper or Partials, but I guess since this is already "frontend-related" we could just as well use a frontend component approach here, and that might even be re-usable for other places in the future?) What do you think?
  4. Philipp Kuhlmay commented on patch set 1 06/17/24, 15:53

    Reply Unresolved

    I had the same idea. My code is only a first draft, so others can check this out and comment their ideas. ATM I am not sure how to solve it, either with a lit element or with Fluid Partials. But you are totally right, this still needs to be improved a bit.
  5. Philipp Kuhlmay marked it work in progress 07/05/24, 09:21

  6. Philipp Kuhlmay uploaded patch set 2 V +1 07/05/24, 09:33

  7. core-ci voted on patch set 2 V +1 07/05/24, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61031

  8. Philipp Kuhlmay updated the commit message in patch set 3 V +1 07/05/24, 15:20

  9. core-ci voted on patch set 3 V +1 07/05/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61062

  10. Philipp Kuhlmay uploaded patch set 4 V +1 07/12/24, 09:49

  11. core-ci voted on patch set 4 V +1 07/12/24, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61470

  12. Benni Mack abandoned the change 04/13/25, 12:05

    abandoned, can be revived later.