84739[FEATURE] Add different code examples for EXT:styleguide
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 812
-
Philipp Kuhlmay uploaded patch set 1 06/17/24, 15:31
-
core-ci voted on patch set 1 V +1 06/17/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59746
-
Garvin Hicking commented on patch set 1 06/17/24, 15:38
This is a cool idea and would be less cluttered. I wonder though if markup like this (accordions with labels and heads) might be put in a lit element instead, so that all the boilerplate HTML doesn't need repeating? (First I thought about a BE ViewHelper or Partials, but I guess since this is already "frontend-related" we could just as well use a frontend component approach here, and that might even be re-usable for other places in the future?) What do you think? -
Philipp Kuhlmay commented on patch set 1 06/17/24, 15:53
Reply Unresolved
I had the same idea. My code is only a first draft, so others can check this out and comment their ideas. ATM I am not sure how to solve it, either with a lit element or with Fluid Partials. But you are totally right, this still needs to be improved a bit. -
Philipp Kuhlmay marked it work in progress 07/05/24, 09:21
-
Philipp Kuhlmay uploaded patch set 2
V +107/05/24, 09:33 -
core-ci voted on patch set 2 V +1 07/05/24, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61031
-
Philipp Kuhlmay updated the commit message in patch set 3
V +107/05/24, 15:20 -
core-ci voted on patch set 3 V +1 07/05/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61062
-
Philipp Kuhlmay uploaded patch set 4
V +107/12/24, 09:49 -
core-ci voted on patch set 4 V +1 07/12/24, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61470
-
Benni Mack abandoned the change 04/13/25, 12:05
abandoned, can be revived later.