84751[TASK] Use VARCHAR(255) over TINYTEXT
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 3
Files 8
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+9 −2
- typo3/sysext/core/Classes/ServiceProvider.php+1 −0
- typo3/sysext/core/Configuration/TCA/sys_file_collection.php+1 −0
- typo3/sysext/core/Configuration/TCA/sys_file_metadata.php+2 −0
- typo3/sysext/core/ext_tables.sql+0 −11
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-corrupt-image.xml+6 −6
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image-but-not-included.xml+6 −6
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image.xml+6 −6
Review log 1014
-
Christian Kuhn uploaded patch set 1 06/18/24, 09:30
-
Anja Leichsenring voted on patch set 1 CR +1 V +1 06/18/24, 09:34
-
core-ci voted on patch set 1 V -1 06/18/24, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59788
-
Christian Kuhn commented on patch set 1 CR -1 06/18/24, 11:12
mmmh. subtle change in placeholder handling as shown by ac tests. needs investigation. -
Benni Mack marked it work in progress 03/28/25, 13:45
-
Andreas Kienast commented on patch set 1 05/05/25, 12:39
Unresolved
I found the reason / a possible solution for the failing acceptance test: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89299 The reason is that the acceptance tests wants to enable the checkbox. With the schema that's generated with this change, the checkboxes are already enabled, hence codeception doesn't do anything meaningful. -
Andreas Kienast uploaded patch set 2
CR +1V +105/07/25, 13:06 -
core-ci voted on patch set 2 V -1 05/07/25, 13:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78635
-
Andreas Kienast uploaded patch set 3
V -105/08/25, 05:54 -
core-ci voted on patch set 3 V -1 05/08/25, 06:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78655
-
Andreas Kienast uploaded patch set 4
V -105/08/25, 08:15 -
Andreas Kienast commented on patch set 4 05/08/25, 08:17
Unresolved
Changing the field types magically changes the result ordering in Postgres. This revealed an actual bug in MetaDataRepository as multiple results were returned (workspace 0 and 1), whose order is now reversed. This probably also affects the failing acceptance tests. This needs way more debugging why this is the case _at all_ and how to solve this properly. -
core-ci voted on patch set 4 V -1 05/08/25, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78659
-
Christian Kuhn abandoned the change 04/21/26, 14:55