Review main Abandoned

84751[TASK] Use VARCHAR(255) over TINYTEXT

Christian Kuhn CR 0 V -1 Normal +31 −31 updated 04/21/26, 14:55

Commit message

A couple of database columns currently use TINYTEXT.
This gives a 255 *bytes* length field, as opposed to
VARCHAR(255), which is 255 *chars*. VARCHAR is the
correct storage format in such cases.
The patch changes these fields (by removing default
TCA schema overrides in ext_tables.sql).
Note TEXT has implicit DEFAULT NULL, which is now
reflected by 'nullable' => true in TCA for a couple
of fields that where configured as such, yet. This
gives us the "null checkbox" for sys_file_metadata,
but is technically the correct solution and avoids
upgrade issues where existing rows would otherwise
need a transition from null to empty string.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 3

Files 8

Review log 1014

  1. Christian Kuhn uploaded patch set 1 06/18/24, 09:30

  2. Anja Leichsenring voted on patch set 1 CR +1 V +1 06/18/24, 09:34

  3. core-ci voted on patch set 1 V -1 06/18/24, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59788

  4. Christian Kuhn commented on patch set 1 CR -1 06/18/24, 11:12

    mmmh. subtle change in placeholder handling as shown by ac tests. needs investigation.
  5. Benni Mack marked it work in progress 03/28/25, 13:45

  6. Andreas Kienast commented on patch set 1 05/05/25, 12:39

    Unresolved

    I found the reason / a possible solution for the failing acceptance test: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89299 The reason is that the acceptance tests wants to enable the checkbox. With the schema that's generated with this change, the checkboxes are already enabled, hence codeception doesn't do anything meaningful.
  7. Andreas Kienast uploaded patch set 2 CR +1 V +1 05/07/25, 13:06

  8. core-ci voted on patch set 2 V -1 05/07/25, 13:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78635

  9. Andreas Kienast uploaded patch set 3 V -1 05/08/25, 05:54

  10. core-ci voted on patch set 3 V -1 05/08/25, 06:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78655

  11. Andreas Kienast uploaded patch set 4 V -1 05/08/25, 08:15

  12. Andreas Kienast commented on patch set 4 05/08/25, 08:17

    Unresolved

    Changing the field types magically changes the result ordering in Postgres. This revealed an actual bug in MetaDataRepository as multiple results were returned (workspace 0 and 1), whose order is now reversed. This probably also affects the failing acceptance tests. This needs way more debugging why this is the case _at all_ and how to solve this properly.
  13. core-ci voted on patch set 4 V -1 05/08/25, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78659

  14. Christian Kuhn abandoned the change 04/21/26, 14:55