Review main Merged

84774[TASK] Have TEXT for type=input length > 255

Christian Kuhn CR +2 V +2 Normal +65 −4 updated 06/18/24, 13:46

Commit message

Long VARCHAR() fields tend to eat up quite a bit of
"65k bytes maximum row size" space, especially with
utf8mb4.
The patch changes TCA type="input" fields longer than
255 chars from VARCHAR() to TEXT (65k bytes). This
looks like a sane tradeoff between limits and
storage efficiency.
Extension authors who need or want to override default
TCA schema details for whatever reason, can of course
do so by defining something specific in ext_tables.sql.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Wand +1
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 06/18/24, 12:01

  2. core-ci voted on patch set 1 V -1 06/18/24, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59796

  3. Christian Kuhn uploaded patch set 2 V -1 06/18/24, 12:47

  4. core-ci voted on patch set 2 V +1 06/18/24, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59801

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 06/18/24, 13:26

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 06/18/24, 13:37

  7. Oliver Wand voted on patch set 2 CR +1 06/18/24, 13:39

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 06/18/24, 13:46

  9. Christian Kuhn merged patch set 3 06/18/24, 13:46