Review main Abandoned

84777[WIP][TASK] Use Dependency Injection for MemorySpool transport

Garvin Hicking CR 0 V 0 Easy +7 −9 updated 12/18/24, 13:31

Commit message

This patch does not fix the issue (yet).

NOTE: Several other places use
"TODO: Use DI to inject the MailerInterface"
as introduced in #97747:

- typo3/sysext/backend/Classes/EventListener/
  FailedLoginAttemptNotification.php
- typo3/sysext/core/Classes/Command/SendEmailCommand.php
- typo3/sysext/core/Classes/Mail/MailMessage.php
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 57

  1. Garvin Hicking uploaded patch set 1 06/18/24, 13:22

  2. core-ci voted on patch set 1 V +1 06/18/24, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59806

  3. Mathias Brodala commented on patch set 1 06/18/24, 14:17

    MemorySpool.php:61

    This must be mandatory, not optional.
  4. Garvin Hicking commented on patch set 1 06/18/24, 15:26

    MemorySpool.php:61 Reply Unresolved

    Then I get this error: ``` (1/1) ArgumentCountError Too few arguments to function TYPO3\CMS\Core\Mail\MemorySpool::__construct(), 0 passed in /var/www/html/typo3-core/typo3/sysext/core/Classes/Utility/GeneralUtility.php on line 2809 and at least 1 expected ``` (this happens when setting the [MAIL][transport_spool_type]=memory option and access Install Tool > Environment) Not sure if this happens because the Install Tool runs in this "safe mode" that doesn't fully utilize DI, I guess?!
  5. Benni Mack updated the commit message in patch set 2 V +1 10/18/24, 13:33

  6. core-ci voted on patch set 2 V -1 10/18/24, 22:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67993

  7. Garvin Hicking abandoned the change 12/18/24, 13:31

    I don't think this will get addressed easily and requires more groundwork first