84777[WIP][TASK] Use Dependency Injection for MemorySpool transport
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 2
Review log 57
-
Garvin Hicking uploaded patch set 1 06/18/24, 13:22
-
core-ci voted on patch set 1 V +1 06/18/24, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59806
-
Mathias Brodala commented on patch set 1 06/18/24, 14:17
-
Garvin Hicking commented on patch set 1 06/18/24, 15:26
MemorySpool.php:61Reply UnresolvedThen I get this error: ``` (1/1) ArgumentCountError Too few arguments to function TYPO3\CMS\Core\Mail\MemorySpool::__construct(), 0 passed in /var/www/html/typo3-core/typo3/sysext/core/Classes/Utility/GeneralUtility.php on line 2809 and at least 1 expected ``` (this happens when setting the [MAIL][transport_spool_type]=memory option and access Install Tool > Environment) Not sure if this happens because the Install Tool runs in this "safe mode" that doesn't fully utilize DI, I guess?! -
Benni Mack updated the commit message in patch set 2
V +110/18/24, 13:33 -
core-ci voted on patch set 2 V -1 10/18/24, 22:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67993
-
Garvin Hicking abandoned the change 12/18/24, 13:31
I don't think this will get addressed easily and requires more groundwork first
MemorySpool.php:61