84779[BUGFIX] Allow to open info modal window
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 3
Files 1
Review log 1418
-
Daniel Gohlke uploaded patch set 1 06/18/24, 14:32
-
core-ci voted on patch set 1 V +1 06/18/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59813
-
Oli Bartsch updated the commit message in patch set 2
V +106/18/24, 16:01 -
Oli Bartsch commented on patch set 2 CR +1 V +1 06/18/24, 16:01
EditDocumentController is not using the setting directly, but the FormEngine containers, e.g. FilesControlContainer do. In the best case, we should add the setting in the components, which are actually using it. However since this is a very general setting, which is also added globally in the BackendController, I'm fine in this case. Since this isn't a priority bugfix I removed 11.5. -
core-ci voted on patch set 2 V +1 06/18/24, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59816
-
Garvin Hicking voted on patch set 2 CR +1 V +1 06/18/24, 18:21
-
Garvin Hicking commented on patch set 2 06/18/24, 18:23
Would maybe: Resolves: #99467 Resolves: #99695 be appropriate to add? I couldn't test that right now, but am hopeful it would address that -
Garvin Hicking commented on patch set 2 06/18/24, 18:24
Reply
(setting to unresolved) -
Daniel Gohlke commented on patch set 2 06/18/24, 18:34
Reply
I'm not sure how this is handled. A backport to TYPO3 v11 is currently not planned, as it is not a priority bugfix. So both tickets will not be solved directly. If it stays that way, I could put a patch in both tickets. However, one of them does not seem to be a composer based installation, so that the patch is probably more difficult to apply. -
Garvin Hicking commented on patch set 2 06/18/24, 18:42
Reply
Ah, sorry for being brief about this. If a bug is fixed only in a v13 or v12 version, we usually also close bug reports for version 11. If a bugfix is not applicable to be backported to v11, the ticket can be closed if the bug itself is adressed in later versions. Patches like this could be backported by end-users themselves usually, and even though of course you're welcome to provide specific patches applicable to v11 in those issues, it's not really required. We have to draw a line of product-support at some point and don't want to leave unresolvable issues open for too long. -
Daniel Gohlke commented on patch set 2 06/18/24, 19:40
Reply
@bo@cedev.de What is the official procedure if a solution for TYPO3 v11 is available, but the patch is not ported back to this version? The issue on the forge leads to the assumption that this is still an actively used TYPO3 version. Is this only documented in the forge issue and the patch must somehow be applied independently for this instance? -
Oli Bartsch updated the commit message in patch set 3
CR +1V +106/18/24, 20:33 -
Oli Bartsch commented on patch set 3 CR +1 V +1 06/18/24, 20:33
Reply
Generally, one can create a bug report for every version. It's then checked, whether the bug is still reproducible in the current development branch (main-branch) and if so, it's fixed there and backported to the current LTS (currently v12). If it's a priority bugfix, e.g. because the backend is unusable or a lot of people face the problem, the patch will be backported even to the previous LTS (currently v11). In any other case developers have to apply the patch manually, e.g. via composer patches. In this specific case: There are several reports and the patch is rather small (only on line), I'm fine with backporting it even to v11. -
Garvin Hicking voted on patch set 3 CR +1 V +1 06/18/24, 20:35
-
core-ci voted on patch set 3 V -1 06/18/24, 20:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59825
-
core-ci voted on patch set 3 V +1 06/18/24, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59825
-
Oli Bartsch voted on patch set 3 CR +2 V +2 06/18/24, 21:05
-
Oli Bartsch merged patch set 4 06/18/24, 21:05