Review main Merged

84780[BUGFIX] Show last page of live search with different result-groups

Ayke Halder CR +2 V +2 Easy +12 −4 updated 11/07/24, 06:50

Commit message

If the last page of the live search consists of entries from different
search-providers like Pages and Records it renders correctly now.

Before the counting of total-count of items was wrong. Thereby
`array_fill()` was called with a negative value for the parameter
`count` which resulted in a `ValueError`.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Ayke Halder uploaded patch set 1 06/18/24, 16:57

  2. core-ci voted on patch set 1 V +1 06/18/24, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59817

  3. Ayke Halder updated the commit message in patch set 2 V +1 06/18/24, 17:03

  4. core-ci voted on patch set 2 V +1 06/18/24, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59818

  5. Georg Ringer voted on patch set 2 CR +1 V +1 06/25/24, 12:15

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 10/16/24, 08:35

  7. Oliver Hader updated the commit message in patch set 3 CR +1 V +1 10/18/24, 13:54

  8. Oliver Hader rebased onto patch set 4 10/24/24, 09:14

  9. core-ci voted on patch set 4 V +1 10/24/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68521

  10. Benni Mack voted on patch set 4 CR +1 V +1 11/06/24, 14:46

  11. Garvin Hicking voted on patch set 4 CR +1 V +1 11/06/24, 16:54

  12. Garvin Hicking voted on patch set 4 CR +2 V +2 11/07/24, 06:50

  13. Garvin Hicking merged patch set 5 11/07/24, 06:50