Review main Merged

84781[BUGFIX] Fix image manipulation GUI only operating on 1st crop variant

Garvin Hicking CR +2 V +2 Easy +13 −7 updated 07/01/24, 20:13

Commit message

When multiple crop variants are defined (for example in EXT:styleguide
"Form engine elements - imageManipulation" for "crop_5" with
"mobile" and "desktop), the currently selected aspect ratio
and the size of the cropping box was only computed based on the
first crop variant.

This patch uses a wrapping container for each variant and adjusts
the JavaScript to operate on that context.

The information for the current cropping box size is now also
based on this context.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Benni Mack +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1013

  1. Garvin Hicking uploaded patch set 1 06/18/24, 17:17

  2. core-ci voted on patch set 1 V +1 06/18/24, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59819

  3. Jasmina Ließmann voted on patch set 1 V +1 06/19/24, 13:21

  4. Jasmina Ließmann uploaded patch set 2 V +1 06/19/24, 13:25

  5. Jasmina Ließmann voted on patch set 2 CR +1 V +1 06/19/24, 13:30

  6. core-ci voted on patch set 2 V +1 06/19/24, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59855

  7. Benni Mack voted on patch set 2 CR +1 06/21/24, 09:46

  8. Garvin Hicking uploaded patch set 3 CR +1 V +1 06/24/24, 10:21

    Fix merge conflict
  9. core-ci voted on patch set 3 V +1 06/24/24, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60166

  10. Jasmina Ließmann voted on patch set 3 CR +1 V +1 06/24/24, 10:28

  11. Benni Mack voted on patch set 3 CR +1 V +1 06/25/24, 12:30

  12. Jasmina Ließmann voted on patch set 3 CR +2 V +2 07/01/24, 20:13

  13. Jasmina Ließmann merged patch set 4 07/01/24, 20:13