Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
84782[TASK] Make live search pagination accessible by keyboard
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 19
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/82/84782/19 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/82/84782/19 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/Sass/component/_livesearch.scss+3 −17
- Build/Sources/Sass/component/_pagination.scss+71 −41
- Build/Sources/TypeScript/backend/live-search/element/result/result-pagination.ts7+72 −49
- Build/Sources/TypeScript/backend/toolbar/live-search.ts+1 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+15 −14
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/result/result-pagination.js+26 −26
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/live-search.js+1 −1
Review log 2443
Show 1018 earlier messages
-
Ayke Halder uploaded patch set 1 06/18/24, 17:45
-
core-ci voted on patch set 1 V +1 06/18/24, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59820
-
Ayke Halder uploaded patch set 2
V +106/18/24, 17:53 -
core-ci voted on patch set 2 V +1 06/18/24, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59821
-
Georg Ringer updated the commit message in patch set 3
V +106/18/24, 19:27 -
core-ci voted on patch set 3 V +1 06/18/24, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59823
-
Ayke Halder uploaded patch set 4
V +106/19/24, 05:14 -
core-ci voted on patch set 4 V -1 06/19/24, 05:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59841
-
Ayke Halder uploaded patch set 5
V -106/19/24, 05:29 -
core-ci voted on patch set 5 V +1 06/19/24, 05:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59842
-
Ayke Halder uploaded patch set 6
V +106/20/24, 18:15 -
core-ci voted on patch set 6 V +1 06/20/24, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59941
-
Ayke Halder voted on patch set 6 CR +1 V +1 06/21/24, 09:39
-
Ayke Halder voted on patch set 6 CR 0 V 0 08/22/24, 20:08
-
Ayke Halder uploaded patch set 7
V +109/19/24, 14:38 -
core-ci voted on patch set 7 V +1 09/19/24, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66223
-
Ayke Halder uploaded patch set 8
V +109/19/24, 15:59 -
core-ci voted on patch set 8 V +1 09/19/24, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66227
-
Ayke Halder updated the commit message in patch set 9
V +109/19/24, 16:08 -
core-ci voted on patch set 9 V +1 09/19/24, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66228
-
Ayke Halder uploaded patch set 10
V +109/19/24, 16:24 -
Ayke Halder updated the commit message in patch set 11 09/19/24, 16:27
-
core-ci voted on patch set 10 V +1 09/19/24, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66229
-
core-ci voted on patch set 11 V +1 09/19/24, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66231
-
Ayke Halder updated the commit message in patch set 12
V +109/19/24, 16:37 -
Ayke Halder updated the commit message in patch set 13 09/19/24, 16:41
-
core-ci voted on patch set 12 V +1 09/19/24, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66232
-
core-ci voted on patch set 13 V +1 09/19/24, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66233
-
Ayke Halder uploaded patch set 14
V +109/19/24, 17:13 -
core-ci voted on patch set 14 V +1 09/19/24, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66237
-
Ayke Halder uploaded patch set 15
V +109/22/24, 14:37 -
core-ci voted on patch set 15 V +1 09/22/24, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66396
-
Benjamin Franzke commented on patch set 15 09/23/24, 05:33
result-pagination.ts:132We should implement rtl support into the icon API for semantic icons. let's not use "previous" for forward on rtl, this is not good…result-pagination.ts:146No createRef()/ref() needed, we can just use `e.currentTarget`, as the event handler is attached to the button this property will always deliver the respective button. -
Ayke Halder commented on patch set 15 09/23/24, 06:09
result-pagination.ts:82ReplyResultPagination is about rendering ResaultPagination. There might be more functionality implemented in the pagination itself: E.g. like properly deciding how many buttons to render depending on the available space. So I do not like to put all 5+ functions needed for the button-state into the ResultPagination. And I also do not like to copy-paste the button-state logic into each button-rendering inside ResultPagination - as the button-rendering-code is used 5 times. ---- The ResultPagination is not recreated every rendering her in search-pagination-context. It's just `this.pagination` which gets updated - and the ResultPagination updates and renders accordingly. https://github.com/TYPO3/typo3/blob/df5fd788639249c19b3de3d26154c0b039c23b70/Build/Sources/TypeScript/backend/toolbar/live-search.ts#L245-L248 ```js private updatePagination(pagination: Pagination): void { const paginationElement: ResultPagination = document.querySelector('typo3-backend-live-search-result-pagination'); paginationElement.pagination = pagination; } ```result-pagination.ts:132ReplyAcknowledgedresult-pagination.ts:146ReplyAcknowledged -
Ayke Halder rebased onto patch set 16
V +109/23/24, 06:29 -
core-ci voted on patch set 16 V +1 09/23/24, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66410
-
Ayke Halder uploaded patch set 17
V +109/24/24, 14:51 -
core-ci voted on patch set 17 V +1 09/24/24, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66500
-
Ayke Halder uploaded patch set 18
V +109/24/24, 19:49 -
core-ci voted on patch set 18 V +1 09/24/24, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66520
-
Ayke Halder uploaded patch set 19
V +109/24/24, 20:35 -
core-ci voted on patch set 19 V +1 09/24/24, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66525
-
Ayke Halder commented on patch set 19 09/24/24, 21:06
This change solves the problem of reusability of a button-component: By using `part`/`exportparts` HTML-attributes the styling can be completely implemented by an outer component - even when the shadow-root is closed. IMO this is a big point to really implement general purpose LitElements ('atom') - which then can be re-used inside multiple other LitElements ('organism'). Any styling can then be completely implemented inside those 'organisms'. The outsourcing of some functionality into its own small LitElement 'atom', can now done without hindering the approach of an 'organism'-based CSS-styles encapsulation.result-pagination.ts:82Reply UnresolvedOn these button-instances: The buttons were really recreated on every rendering while using the custom JS-class (non-LitElement) from Patchset 17 https://review.typo3.org/c/Packages/TYPO3.CMS/+/84782/17 ---- Now this change is further refined – based again on Patchset 14 with a button-component implemented as LitElement: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84782/14 The current Patchset is 19: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84782/19
result-pagination.ts:82