84783[BUGFIX] Remove all restrictions in user creation command
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Command/CreateBackendUserCommand.php+7 −5
- typo3/sysext/backend/Tests/Functional/Command/Fixtures/Expected/be_users_after_admin.csv+4 −2
- typo3/sysext/backend/Tests/Functional/Command/Fixtures/Expected/be_users_after_maint.csv+4 −2
- typo3/sysext/backend/Tests/Functional/Command/Fixtures/Expected/be_users_after_normal.csv+4 −2
- typo3/sysext/backend/Tests/Functional/Command/CreateBackendUserCommandTest.php2+13 −4
- typo3/sysext/backend/Tests/Functional/Fixtures/be_users_create_backend_command.csvnew+6 −0
Review log 1721
-
Georg Ringer uploaded patch set 1 06/18/24, 19:25
-
Georg Ringer commented on patch set 1 06/18/24, 19:26
This change is ready for review. -
core-ci voted on patch set 1 V +1 06/18/24, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59822
-
Oliver Klee commented on patch set 1 06/19/24, 06:19
Please let's cover this with a regression test so nobody will re-break this later when doing cleanup. -
Oliver Klee commented on patch set 1 06/19/24, 06:31
I think it would also be helpful to explain in the commit message _why_ we do this. The people won't need to read the code to find out the rationale for this change. -
Georg Ringer uploaded patch set 2
V +106/19/24, 19:30 -
core-ci voted on patch set 2 V -1 06/19/24, 19:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59862
-
Georg Ringer uploaded patch set 3
V -106/19/24, 19:49 -
core-ci voted on patch set 3 V +1 06/19/24, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59863
-
Garvin Hicking commented on patch set 3 CR +1 V +1 06/19/24, 20:08
Nice catch on the tests! -
Stefan Bürk commented on patch set 3 06/19/24, 20:09
CreateBackendUserCommandTest.php:162Please move dataProvider before the test method, and also use assoc array keys matching test method argument name. ```php yield 'existing admin' => ['username' => 'admin']; ``` -
Stefan Bürk voted on patch set 3 CR -1 06/19/24, 20:09
-
Georg Ringer uploaded patch set 4
CR +1V +106/19/24, 20:16 -
core-ci voted on patch set 4 V +1 06/19/24, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59864
-
Stefan Bürk commented on patch set 4 06/19/24, 20:28
CreateBackendUserCommandTest.php:162ReplyDone -
Garvin Hicking voted on patch set 4 CR +1 V +1 06/19/24, 20:28
-
Benni Mack voted on patch set 4 CR +1 V +1 06/19/24, 20:36
-
Oli Bartsch voted on patch set 4 CR +1 V +1 06/20/24, 07:17
-
Georg Ringer voted on patch set 4 CR +2 V +2 06/20/24, 09:29
-
Georg Ringer merged patch set 5 06/20/24, 09:30