Review main Merged

84783[BUGFIX] Remove all restrictions in user creation command

Georg Ringer CR +2 V +2 Normal +38 −15 updated 06/20/24, 09:30

Commit message

Implement what is already commented by removing all restrictions when
comparing given username with all existing usernames. Even the username
of a deleted or disabled user must not be reused.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1721

  1. Georg Ringer uploaded patch set 1 06/18/24, 19:25

  2. Georg Ringer commented on patch set 1 06/18/24, 19:26

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 06/18/24, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59822

  4. Oliver Klee commented on patch set 1 06/19/24, 06:19

    Please let's cover this with a regression test so nobody will re-break this later when doing cleanup.
  5. Oliver Klee commented on patch set 1 06/19/24, 06:31

    I think it would also be helpful to explain in the commit message _why_ we do this. The people won't need to read the code to find out the rationale for this change.
  6. Georg Ringer uploaded patch set 2 V +1 06/19/24, 19:30

  7. core-ci voted on patch set 2 V -1 06/19/24, 19:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59862

  8. Georg Ringer uploaded patch set 3 V -1 06/19/24, 19:49

  9. core-ci voted on patch set 3 V +1 06/19/24, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59863

  10. Garvin Hicking commented on patch set 3 CR +1 V +1 06/19/24, 20:08

    Nice catch on the tests!
  11. Stefan Bürk commented on patch set 3 06/19/24, 20:09

    CreateBackendUserCommandTest.php:162

    Please move dataProvider before the test method, and also use assoc array keys matching test method argument name. ```php yield 'existing admin' => ['username' => 'admin']; ```
  12. Stefan Bürk voted on patch set 3 CR -1 06/19/24, 20:09

  13. Georg Ringer uploaded patch set 4 CR +1 V +1 06/19/24, 20:16

  14. core-ci voted on patch set 4 V +1 06/19/24, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59864

  15. Stefan Bürk commented on patch set 4 06/19/24, 20:28

    CreateBackendUserCommandTest.php:162 Reply

    Done
  16. Garvin Hicking voted on patch set 4 CR +1 V +1 06/19/24, 20:28

  17. Garvin Hicking commented on patch set 4 06/19/24, 20:29

    Reply

    Done

    Reply

    Done
  18. Benni Mack voted on patch set 4 CR +1 V +1 06/19/24, 20:36

  19. Oli Bartsch voted on patch set 4 CR +1 V +1 06/20/24, 07:17

  20. Georg Ringer voted on patch set 4 CR +2 V +2 06/20/24, 09:29

  21. Georg Ringer merged patch set 5 06/20/24, 09:30