Review main Merged

84786[TASK] Deprecate `Utility.updateQueryStringParameter()`

Andreas Kienast CR +2 V +2 Normal +52 −1 updated 06/19/24, 13:41

Commit message

The method `Utility.updateQueryStringParameter()` from the module
`@typo3/backend/utility.js` was introduced in TYPO3 v8 as a bugfix for
highlighting in the old ExtJS-based page tree. With removal of ExtJS in
TYPO3 v9, the method became unused since then.

Since a safe removal of the method cannot be guaranteed as this point,
it is therefore deprecated.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 810

  1. Andreas Kienast uploaded patch set 1 06/19/24, 13:12

  2. Andreas Kienast updated the commit message in patch set 2 06/19/24, 13:12

  3. core-ci voted on patch set 1 V +1 06/19/24, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59853

  4. core-ci voted on patch set 2 V +1 06/19/24, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59854

  5. Garvin Hicking commented on patch set 2 06/19/24, 13:21

    Needs a deprecation RST?
  6. Garvin Hicking commented on patch set 2 06/19/24, 13:21

    Reply

    nvm
  7. Garvin Hicking voted on patch set 2 CR +1 V +1 06/19/24, 13:22

  8. Jasmina Ließmann voted on patch set 2 CR +1 V +1 06/19/24, 13:39

  9. Andreas Kienast voted on patch set 2 CR +2 V +2 06/19/24, 13:40

  10. Andreas Kienast merged patch set 3 06/19/24, 13:41