Review main Merged

84789[TASK] Rename twitter to x in labels

Georg Ringer CR +2 V +2 Easy +6 −6 updated 06/20/24, 13:06

Commit message

As twitter has been renamed to X, the labels in the page settings are
adopted too. As the meta tags itself are still using twitter, also the
database fields keep their name.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1518

  1. Georg Ringer uploaded patch set 1 06/19/24, 20:44

  2. Georg Ringer commented on patch set 1 06/19/24, 20:44

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 06/19/24, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59870

  4. Garvin Hicking commented on patch set 1 06/19/24, 20:57

    Sorry I can't vote on this in good conscience. This "X" just looks stupid.
  5. Benni Mack commented on patch set 1 06/19/24, 21:07

    I suggest we just name it "X / Twitter" in all labels?
  6. Garvin Hicking commented on patch set 1 06/19/24, 21:36

    Reply

    That would work for me. I would keep current DB field names to not create code migration issues.
  7. Georg Ringer uploaded patch set 2 V +1 06/19/24, 21:59

  8. core-ci voted on patch set 2 V +1 06/19/24, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59879

  9. Garvin Hicking commented on patch set 2 CR +1 V +1 06/19/24, 22:30

    X marks the sloth
  10. Simon Schaufelberger voted on patch set 2 CR +1 V +1 06/19/24, 23:04

  11. Jasmina Ließmann commented on patch set 2 06/20/24, 12:03

    Index.rst:178

    Should this be labelled as "X / Twitter Cards" instead of "X Cards" only? Just to use the same wording as in other places.
  12. Christian Kuhn commented on patch set 2 06/20/24, 12:54

    Index.rst:178 Reply

    Done
  13. Christian Kuhn uploaded patch set 3 CR +1 V +1 06/20/24, 12:54

  14. Christian Kuhn voted on patch set 3 CR +1 V +1 06/20/24, 12:54

  15. Jasmina Ließmann voted on patch set 3 CR +1 V +1 06/20/24, 12:54

  16. Christian Kuhn voted on patch set 3 CR +2 V +2 06/20/24, 12:55

  17. core-ci voted on patch set 3 V +1 06/20/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59914

  18. Christian Kuhn merged patch set 4 06/20/24, 13:06