Review main Abandoned

84791[WIP][TASK] mysql/mariadb engine change - default InnoDB

Stefan Bürk CR 0 V 0 Normal +55 −7 updated 11/07/24, 11:48

Commit message

--------------------------------------------------------

`tableEngineIsChangedToDefaultInnoDB()` should fail on
MariaDB and MySQL platforms:

Build/Scripts/runTests.sh -s functional -d mysql ...

* -- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php
  is green

where as

* -- --filter 'typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php' \
  typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php

fails as expected (for now). Same for `--filter 'changeTableEngine'`

!!! Must be investigated first !!!!!

weirdo - moving both engine change test methods UP directly
below the tearDown() they will fail :/ :/

Enabling PHPUnit `processIsolation="true"` in the FunctionalTests.xml
also let the test fail oOoOoO

--------------------------------------------------------

Note: Currently, there is no default engine defined and
not changed by the Database Analyser (backend) and not
switching the engine - unless it is explicitly defined
in the `ext_tables.sql`.

This change enriches the `changeTableEngine()` test and
adds additional `tableEngineIsChangedToDefaultInnoDB()`
test to cover these cases.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 712

  1. Stefan Bürk uploaded patch set 1 06/20/24, 01:38

  2. core-ci voted on patch set 1 V -1 06/20/24, 01:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59883

  3. Stefan Bürk uploaded patch set 2 V -1 06/20/24, 02:26

  4. core-ci voted on patch set 2 V +1 06/20/24, 02:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59885

  5. Stefan Bürk uploaded patch set 3 V +1 06/20/24, 02:37

  6. core-ci voted on patch set 3 V +1 06/20/24, 02:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59886

  7. Stefan Bürk updated the commit message in patch set 4 V +1 06/20/24, 02:42

  8. core-ci voted on patch set 4 V +1 06/20/24, 02:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59887

  9. Stefan Bürk updated the commit message in patch set 5 V +1 06/20/24, 02:52

  10. core-ci voted on patch set 5 V +1 06/20/24, 02:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59888

  11. Benjamin Franzke commented on patch set 5 11/05/24, 09:27

    Unresolved

    Hey, just found this commit as conflict to https://review.typo3.org/c/Packages/TYPO3.CMS/+/86878 (sorry, for that separate patchset, I didn't found yours earlier) Question: Why should the test fail with the current/old state? newTable.sql already explicitly defined `ENGINE=InnoDB` in https://github.com/TYPO3/typo3/blob/9819ed85807fb3804be4d9c559a8b16b3970435d/typo3/sysext/core/Tests/Functional/Database/Fixtures/newTable.sql which means that the schema migration switched back from MyISAM to InnoDB as requested. (Note: It should fail if newTable.sql has no ENGINE defined, which is not the case currently…) I think/hope I covered all these cases in the tests for https://review.typo3.org/c/Packages/TYPO3.CMS/+/86878
  12. Benjamin Franzke abandoned the change 11/07/24, 11:48

    Implemented in > 86878: [BUGFIX] Apply InnoDB as default to CREATE TABLE options | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86878 (and sorry that I missed the existence of your patch initially)