Review main Abandoned

84803[FEATURE] Add lit element for tabs

Philipp Kuhlmay CR 0 V 0 Normal +191 −0 updated 03/28/25, 10:14

Commit message

This provides a new lit element with which you can now use tabs inside your own lit component.

A tab can be included like this:
<typo3-backend-tab componentId="notice-tab">
    <typo3-tab-content tab-title="tab one"><p>Tab content for tab one</p></typo3-tab-content>
    <typo3-tab-content tab-title="tab two"><p>Tab content for tab two</p></typo3-tab-content>
    <typo3-tab-content tab-title="tab three"><p>Tab content for tab three</p></typo3-tab-content>
</typo3-backend-tab>

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 2134

Show 59 earlier messages
  1. Philipp Kuhlmay uploaded patch set 1 06/20/24, 15:34

  2. core-ci voted on patch set 1 V +1 06/20/24, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59926

  3. Philipp Kuhlmay marked it work in progress 07/05/24, 09:41

  4. Philipp Kuhlmay rebased onto patch set 2 V +1 07/05/24, 09:52

  5. core-ci voted on patch set 2 V +1 07/05/24, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61037

  6. Philipp Kuhlmay uploaded patch set 3 V +1 07/05/24, 12:08

  7. core-ci voted on patch set 3 V +1 07/05/24, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61047

  8. Philipp Kuhlmay uploaded patch set 4 V +1 07/05/24, 12:25

  9. core-ci voted on patch set 4 V +1 07/05/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61049

  1. Philipp Kuhlmay updated the commit message in patch set 5 V +1 07/05/24, 12:41

  2. core-ci voted on patch set 5 V +1 07/05/24, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61050

  3. Philipp Kuhlmay uploaded patch set 6 V +1 07/12/24, 11:03

  4. core-ci voted on patch set 6 V +1 07/12/24, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61476

  5. Philipp Kuhlmay commented on patch set 6 07/12/24, 11:28

    This change is ready for review.

    Unresolved

    You might need to add the following to your Fluid template to load the module: <f:be.pageRenderer includeJavaScriptModules="{ 0: '@typo3/backend/element/tab-element.js' }"> </f:be.pageRenderer> Currently this is not loaded somewhere else so it is not working at the moment, without including it directly. Any hints on this are welcome.
  6. Simon Schaufelberger updated the commit message in patch set 7 V +1 07/12/24, 11:53

  7. core-ci voted on patch set 7 V +1 07/12/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61482

  8. Philipp Kuhlmay rebased onto patch set 8 V +1 11/22/24, 14:29

  9. core-ci voted on patch set 8 V +1 11/22/24, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70043

  10. Philipp Kuhlmay uploaded patch set 9 V +1 11/22/24, 15:16

  11. Philipp Kuhlmay uploaded patch set 10 11/22/24, 15:19

  12. Philipp Kuhlmay marked it work in progress 11/22/24, 15:20

  13. core-ci voted on patch set 9 V +1 11/22/24, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70048

  14. core-ci voted on patch set 10 V +1 11/22/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70049

  15. Philipp Kuhlmay uploaded patch set 11 V +1 11/22/24, 15:27

  16. core-ci voted on patch set 11 V +1 11/22/24, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70051

  17. Philipp Kuhlmay marked it ready for review 11/22/24, 15:39

  18. Simon Schaufelberger commented on patch set 11 11/22/24, 17:10

    Unresolved

    There is a feature rest file but here it's TASK?
  19. Philipp Kuhlmay updated the commit message in patch set 12 V +1 11/23/24, 15:58

  20. core-ci voted on patch set 12 V +1 11/23/24, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70085

  21. Philipp Kuhlmay rebased onto patch set 13 V +1 02/07/25, 09:14

  22. core-ci voted on patch set 13 V +1 02/07/25, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73701

  23. Benjamin Franzke commented on patch set 13 CR -1 03/04/25, 07:23

    tab-element.ts:52 Unresolved

    This slot-like "hack" will break once a component rerenders `<typo3-backend-tab>` and the `<typo3-tab-content>` children, as these children are moved into nested positions by the `typo3-backend-tab` component, but would be tried to be moved to the initial positions by outside components. Hard to explain, but I fear we cannot fake `<slot>'`s like that. Sorry. I understand why you did that, but if we want this kind of interface, we really need to use shadow dom and define tab-behaviour and classes in shadow dom, in order to use real slots.
  24. Benni Mack marked it work in progress 03/28/25, 10:13

  25. Benni Mack abandoned the change 03/28/25, 10:14

    will abandon it for the time being, can be restored later, if somebody wants to pick it up again