Review main Merged

84804[BUGFIX] Provide and handle module aliases in JS context

Oli Bartsch CR +2 V +2 Easy +12 −4 updated 06/24/24, 07:47

Commit message

Since #96515, is's possible to configure aliases
for backend modules. Those are handled by the
UriBuilder to allow using those aliases for
building links to the corresponding module.

Using the ActionDispatcher JS component for
building module links via the
"TYPO3.ModuleMenu.showModule" action, it's
now also possible to use corresponding aliases.

Therefore, the BackendController now adds
the module aliases to the module information
JS array and the module JS component properly
checks for those aliases when resolving a
given module name / identifier.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 79

  1. Oli Bartsch uploaded patch set 1 06/20/24, 16:11

  2. core-ci voted on patch set 1 V -1 06/20/24, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59929

  3. Oli Bartsch uploaded patch set 2 V -1 06/20/24, 16:41

  4. core-ci voted on patch set 2 V +1 06/20/24, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59935

  5. Andreas Kienast voted on patch set 2 CR +1 06/21/24, 06:08

  6. Andreas Kienast voted on patch set 2 V +1 06/21/24, 13:12

  7. Benni Mack voted on patch set 2 CR +1 V +1 06/24/24, 07:24

  8. Oli Bartsch voted on patch set 2 CR +2 V +2 06/24/24, 07:47

  9. Oli Bartsch merged patch set 3 06/24/24, 07:47