Review main Merged

84805[TASK] Update display of overview table in "Redirects" module

Jasmina Ließmann CR +2 V +2 Hard +154 −98 updated 06/21/24, 12:04

Commit message

The redirects overview table has been revised to improve the UX.

Previously, the table fields took up as much space as their content
allowed. Redirects with a long source and/or destination path stretched
the table rows, which caused unwanted horizontal scrolling. The patch
now fixes this and sets a maximum width for these fields.

Furthermore, the "Status Code" and "Protected" fields are now also
managed as separate table columns. The record icon is now placed first
after the multi-record selection checkbox, as with other tables used in
the system.

Further actions, such as viewing the redirect and resetting the hit
counter, have been moved to a separate button group.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1115

  1. Jasmina Ließmann uploaded patch set 1 06/20/24, 16:39

  2. core-ci voted on patch set 1 V -1 06/20/24, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59934

  3. Jasmina Ließmann uploaded patch set 2 V -1 06/20/24, 17:01

  4. core-ci voted on patch set 2 V -1 06/20/24, 17:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59937

  5. Jasmina Ließmann uploaded patch set 3 V -1 06/20/24, 17:13

  6. core-ci voted on patch set 3 V +1 06/20/24, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59939

  7. Benni Mack voted on patch set 3 CR +1 V +1 06/21/24, 10:08

  8. Jasmina Ließmann commented on patch set 3 CR -1 06/21/24, 10:12

    on it
  9. Jasmina Ließmann uploaded patch set 4 CR +1 V +1 06/21/24, 10:49

  10. core-ci voted on patch set 4 V +1 06/21/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59992

  11. Jasmina Ließmann commented on patch set 4 06/21/24, 10:57

    Open vor review again.
  12. Jasmina Ließmann commented on patch set 4 06/21/24, 10:59

    Reply

    -v +f ...
  13. Christian Kuhn voted on patch set 4 CR +1 V +1 06/21/24, 12:04

  14. Benni Mack voted on patch set 4 CR +2 V +2 06/21/24, 12:04

  15. Benni Mack merged patch set 5 06/21/24, 12:04