Review 12.4 Merged

84807[BUGFIX] Add scheduler task exception to error message

Christian Kuhn CR +2 V +2 Easy +7 −3 updated 06/20/24, 18:54

Commit message

When a scheduler task throws an exception, an error is logged.
The log message does not tell us the reason for the failure:
> Task failed to execute successfully.
> Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 2

Up to TYPO3 v10, this message did include more information:
> Task failed to execute successfully.
> Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 2,
> Code: 56, OpenSSL SSL_read: Connection reset by peer, errno 104

This behavior was changed (probably unintentional) with patch
"[BUGFIX] Make logger usage PSR-3 compliant"
https://review.typo3.org/c/Packages/TYPO3.CMS/+/69425

Besides the task class and UID, the log message now contains the
exception code, message, file and line.

Example:
> Task failed to execute successfully.
> Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 6,
> Code: 500, "FailTask fail message"
> in /var/www/typo3/vendor/[...]/Classes/Command/FailTask.php#19

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 06/20/24, 17:03

  2. core-ci voted on patch set 1 V +1 06/20/24, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59938

  3. Jasmina Ließmann voted on patch set 1 CR +1 06/20/24, 17:32

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 06/20/24, 18:54

  5. Christian Kuhn merged patch set 2 06/20/24, 18:54