84810[TASK] Allow symlinks instead of directories in directory status
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php+4 −4
- typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php+1 −1
- typo3/sysext/install/Classes/FolderStructure/LinkOrDirectoryNode.php5new+89 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkOrDirectoryNodeTest.phpnew+140 −0
Review log 1925
-
Georg Ringer uploaded patch set 1 06/20/24, 20:03
-
core-ci voted on patch set 1 V -1 06/20/24, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59945
-
Georg Ringer uploaded patch set 2
V -107/10/24, 19:16 -
core-ci voted on patch set 2 V +1 07/10/24, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61330
-
Georg Ringer rebased onto patch set 3
V +102/03/25, 19:55 -
core-ci voted on patch set 3 V +1 02/03/25, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73443
-
Georg Ringer uploaded patch set 4
V +103/27/25, 20:05 -
Georg Ringer commented on patch set 4 03/27/25, 20:05
This change is ready for review. -
core-ci voted on patch set 4 V +1 03/27/25, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76502
-
Stefan Bürk commented on patch set 4 03/27/25, 22:44
I guess we should add tests for the new LinkOrDirectoryNode class. DirectoryNode has tests. -
Simon Schaufelberger commented on patch set 4 03/28/25, 02:11
LinkOrDirectoryNode.php:120node is -
Georg Ringer uploaded patch set 5
V +103/28/25, 10:06 -
core-ci voted on patch set 5 V +1 03/28/25, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76566
-
Garvin Hicking commented on patch set 5 03/28/25, 13:47
Reply
DoneLinkOrDirectoryNode.php:36This method is a 1:1 copy of the extended Directory node class? do we need this redundancy?LinkOrDirectoryNode.php:120ReplyDone -
Stefan Bürk uploaded patch set 6
V +104/01/25, 13:50 -
Stefan Bürk commented on patch set 6 04/01/25, 13:50
LinkOrDirectoryNode.php:36ReplyI'd say no, I'm going to remove it and add a return type to the `DirectoryNode::fixSelf()`. -
Stefan Bürk commented on patch set 6 04/01/25, 13:51
LinkOrDirectoryNode.php:36ReplyThese classes could benefit from finishing returns in general. Follow up. Thanks for taking care of the test @gh@faktor-e.de. -
core-ci voted on patch set 6 V +1 04/01/25, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76795
-
Stefan Bürk voted on patch set 6 CR +1 V +1 04/01/25, 13:58
-
Garvin Hicking voted on patch set 6 CR +1 V +1 04/01/25, 17:15
-
Benni Mack wrote 04/02/25, 06:05
Hashtag added: lolli-feedback -
Christian Kuhn voted on patch set 6 CR +1 V +1 04/07/25, 11:02
-
Georg Ringer voted on patch set 6 CR +2 V +2 04/07/25, 14:45
-
Georg Ringer merged patch set 7 04/07/25, 14:45
-
Benni Mack wrote 04/07/25, 14:55
Hashtag removed: lolli-feedback