Review main Merged

84810[TASK] Allow symlinks instead of directories in directory status

Georg Ringer CR +2 V +2 Normal +234 −5 updated 04/07/25, 14:55

Commit message

The following directories can now also be a symlink:

- fileadmin
- typo3temp
- var
- user_upload

This avoids false positive warnings which especially occur using
continous deployments where such directories are often symlinked.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1925

  1. Georg Ringer uploaded patch set 1 06/20/24, 20:03

  2. core-ci voted on patch set 1 V -1 06/20/24, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59945

  3. Georg Ringer uploaded patch set 2 V -1 07/10/24, 19:16

  4. core-ci voted on patch set 2 V +1 07/10/24, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61330

  5. Georg Ringer rebased onto patch set 3 V +1 02/03/25, 19:55

  6. core-ci voted on patch set 3 V +1 02/03/25, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73443

  7. Georg Ringer uploaded patch set 4 V +1 03/27/25, 20:05

  8. Georg Ringer commented on patch set 4 03/27/25, 20:05

    This change is ready for review.
  9. core-ci voted on patch set 4 V +1 03/27/25, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76502

  10. Stefan Bürk commented on patch set 4 03/27/25, 22:44

    I guess we should add tests for the new LinkOrDirectoryNode class. DirectoryNode has tests.
  11. Simon Schaufelberger commented on patch set 4 03/28/25, 02:11

    LinkOrDirectoryNode.php:120

    node is
  12. Georg Ringer uploaded patch set 5 V +1 03/28/25, 10:06

  13. core-ci voted on patch set 5 V +1 03/28/25, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76566

  14. Garvin Hicking commented on patch set 5 03/28/25, 13:47

    Reply

    Done

    LinkOrDirectoryNode.php:36

    This method is a 1:1 copy of the extended Directory node class? do we need this redundancy?

    LinkOrDirectoryNode.php:120 Reply

    Done
  15. Stefan Bürk uploaded patch set 6 V +1 04/01/25, 13:50

  16. Stefan Bürk commented on patch set 6 04/01/25, 13:50

    LinkOrDirectoryNode.php:36 Reply

    I'd say no, I'm going to remove it and add a return type to the `DirectoryNode::fixSelf()`.
  17. Stefan Bürk commented on patch set 6 04/01/25, 13:51

    LinkOrDirectoryNode.php:36 Reply

    These classes could benefit from finishing returns in general. Follow up. Thanks for taking care of the test @gh@faktor-e.de.
  18. core-ci voted on patch set 6 V +1 04/01/25, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76795

  19. Stefan Bürk voted on patch set 6 CR +1 V +1 04/01/25, 13:58

  20. Garvin Hicking voted on patch set 6 CR +1 V +1 04/01/25, 17:15

  21. Benni Mack wrote 04/02/25, 06:05

    Hashtag added: lolli-feedback
  22. Christian Kuhn voted on patch set 6 CR +1 V +1 04/07/25, 11:02

  23. Georg Ringer voted on patch set 6 CR +2 V +2 04/07/25, 14:45

  24. Georg Ringer merged patch set 7 04/07/25, 14:45

  25. Benni Mack wrote 04/07/25, 14:55

    Hashtag removed: lolli-feedback