Review main Merged

84816[BUGFIX] Provide columnsOnly config as array

Oli Bartsch CR +2 V +2 Easy +16 −16 updated 06/24/24, 15:27

Commit message

Since #104172, the `columnsOnly` configuration
has to be provided in a new format, using
the table name as key and an array of fields
as parameter value.

To prevent deprecation log entries are
the recordlist and filelist JS components
adjusted to use the new format.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 911

  1. Oli Bartsch uploaded patch set 1 06/21/24, 09:52

  2. core-ci voted on patch set 1 V +1 06/21/24, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59988

  3. Benni Mack voted on patch set 1 CR +1 V +1 06/22/24, 06:54

  4. Andreas Kienast commented on patch set 1 06/24/24, 14:38

    recordlist.ts:155

    Why do we need `Array.from()`? According to the definition of `EditRecordsConfiguration.columnsOnly`, it is always an array.

    file-list.ts:286

    Same here.
  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 06/24/24, 15:15

  6. Oli Bartsch commented on patch set 2 06/24/24, 15:15

    recordlist.ts:155 Reply

    Done

    file-list.ts:286 Reply

    Done
  7. core-ci voted on patch set 2 V +1 06/24/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60193

  8. Andreas Kienast voted on patch set 2 CR +1 V +1 06/24/24, 15:24

  9. Benni Mack voted on patch set 2 CR +1 V +1 06/24/24, 15:24

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 06/24/24, 15:27

  11. Oli Bartsch merged patch set 3 06/24/24, 15:27