Review main Merged

84818[TASK] Reduce usage of GeneralUtility::makeInstance in functional tests

Anja Leichsenring CR +2 V +2 Hard +266 −369 updated 06/21/24, 12:53

Commit message

The functional test setup allows for easy access to registered services
via `$this->get` and will not consider any other possible treatments
to classes like e.g. xclassing when running tests. Thus, the usage
of `$this->get` for services and otherwise just `new` is preferred over
GeneralUtility::makeInstance().

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 105

Show 85 more files

Review log 812

  1. Anja Leichsenring uploaded patch set 1 06/21/24, 11:11

  2. core-ci voted on patch set 1 V -1 06/21/24, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59994

  3. Anja Leichsenring uploaded patch set 2 V -1 06/21/24, 11:18

  4. core-ci voted on patch set 2 V +1 06/21/24, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59995

  5. Christian Kuhn uploaded patch set 3 V +1 06/21/24, 12:22

  6. core-ci voted on patch set 3 V +1 06/21/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60012

  7. Christian Kuhn uploaded patch set 4 V +1 06/21/24, 12:38

  8. core-ci voted on patch set 4 V +1 06/21/24, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60014

  9. Christian Kuhn voted on patch set 4 CR +1 V +1 06/21/24, 12:45

  10. Simon Schaufelberger voted on patch set 4 CR +1 V +1 06/21/24, 12:47

  11. Stefan Bürk voted on patch set 4 CR +2 V +2 06/21/24, 12:52

  12. Stefan Bürk merged patch set 5 06/21/24, 12:53