84818[TASK] Reduce usage of GeneralUtility::makeInstance in functional tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 105
- typo3/sysext/backend/Tests/Functional/Controller/BackendControllerTest.php+1 −2
- typo3/sysext/backend/Tests/Functional/Controller/EditDocumentControllerTest.php+1 −2
- typo3/sysext/backend/Tests/Functional/Controller/MfaConfigurationControllerTest.php+5 −9
- typo3/sysext/backend/Tests/Functional/Controller/MfaControllerTest.php+2 −6
- typo3/sysext/backend/Tests/Functional/Controller/MfaSetupControllerTest.php+4 −8
- typo3/sysext/backend/Tests/Functional/Controller/ResetPasswordControllerTest.php+2 −3
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+4 −4
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectTreeItemsTest.php+1 −2
- typo3/sysext/backend/Tests/Functional/Routing/UriBuilderTest.php+7 −8
- typo3/sysext/backend/Tests/Functional/Utility/BackendUtilityTest.php+1 −2
- typo3/sysext/backend/Tests/Functional/View/ValueFormatter/FlexFormValueFormatterTest.php+1 −2
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/Provider/RecoveryCodesProviderTest.php+5 −6
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/Provider/TotpProviderTest.php+5 −9
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/MfaProviderPropertyManagerTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Authentication/GroupResolverTest.php+1 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/GetUniqueTest.php+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SecurityTest.php+3 −3
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/TranslationDiffSourceTest.php+2 −3
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Hooks/PagesTsConfigGuardTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/MultiSite/MultiSiteTest.php+2 −3
Show 85 more files
- typo3/sysext/core/Tests/Functional/DataHandling/Slug/SlugHelperTest.php+1 −3
- typo3/sysext/core/Tests/Functional/DataHandling/Slug/SlugHelperUniqueTest.php+3 −7
- typo3/sysext/core/Tests/Functional/DataHandling/Slug/SlugHelperUniqueWithLanguageTest.php+1 −3
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/AbstractActionTestCase.php+1 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/AbstractDataHandlerActionTestCase.php+2 −3
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php+3 −4
- typo3/sysext/core/Tests/Functional/Domain/RecordFactoryTest.php+2 −2
- typo3/sysext/core/Tests/Functional/LinkHandling/LinkServiceTest.php+1 −1
- typo3/sysext/core/Tests/Functional/PasswordPolicy/Validator/NotCurrentPasswordValidatorTest.php+2 −3
- typo3/sysext/core/Tests/Functional/PasswordPolicy/PasswordPolicyValidatorTest.php+6 −13
- typo3/sysext/core/Tests/Functional/Resource/DefaultUploadFolderResolverTest.php+10 −10
- typo3/sysext/core/Tests/Functional/Resource/FileReferenceTest.php+1 −2
- typo3/sysext/core/Tests/Functional/Resource/ProcessedFileTest.php+1 −2
- typo3/sysext/core/Tests/Functional/Resource/StorageRepositoryTest.php+33 −33
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Tca/BackendGroupsVisibleFieldsTest.php+2 −3
- typo3/sysext/core/Tests/Functional/Tca/BackendUsersVisibleFieldsTest.php+4 −5
- typo3/sysext/core/Tests/Functional/Tca/CategoryVisibleFieldsTest.php+2 −3
- typo3/sysext/core/Tests/Functional/Tca/FileCollectionVisibleFieldsTest.php+2 −3
- typo3/sysext/core/Tests/Functional/Tca/FileMetadataVisibleFieldsTest.php+2 −3
- typo3/sysext/core/Tests/Functional/Tca/FileStorageVisibleFieldsTest.php+2 −3
- typo3/sysext/core/Tests/Functional/Tca/NewsVisibleFieldsTest.php+2 −3
- typo3/sysext/core/Tests/Functional/Tca/PagesVisibleFieldsTest.php+2 −3
- typo3/sysext/core/Tests/Functional/Utility/File/ExtendedFileUtilityTest.php+1 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php+1 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/LazyLoadingProxyTest.php+1 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryLocalizedDataTest.php+5 −6
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+1 −2
- typo3/sysext/extensionmanager/Tests/Functional/Updates/FeLoginModeExtractionUpdateTest.php+1 −2
- typo3/sysext/felogin/Tests/Functional/Tca/ContentVisibleFieldsTest.php+2 −3
- typo3/sysext/filemetadata/Tests/Functional/Tca/FileMetadataVisibleFieldsTest.php+2 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/FileViewHelperTest.php+4 −5
- typo3/sysext/fluid_styled_content/Tests/Functional/Tca/ContentVisibleFieldsTest.php+2 −3
- typo3/sysext/form/Tests/Functional/Domain/Model/Renderable/AbstractRenderableTest.php+2 −3
- typo3/sysext/form/Tests/Functional/Mvc/Validation/CountValidatorTest.php+1 −2
- typo3/sysext/form/Tests/Functional/Mvc/Validation/DateRangeValidatorTest.php+1 −2
- typo3/sysext/form/Tests/Functional/Mvc/Validation/EmptyValidatorTest.php+1 −2
- typo3/sysext/form/Tests/Functional/Mvc/Validation/FileSizeValidatorTest.php+1 −2
- typo3/sysext/form/Tests/Functional/Mvc/Validation/MimeTypeValidatorTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentContentObjectTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+9 −9
- typo3/sysext/frontend/Tests/Functional/DataProcessing/PageContentFetchingProcessorTest.php+1 −2
- typo3/sysext/frontend/Tests/Functional/DataProcessing/RecordTransformationProcessorTest.php+1 −2
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+4 −4
- typo3/sysext/frontend/Tests/Functional/Rendering/AbsoluteUriPrefixRenderingTest.php+1 −2
- typo3/sysext/frontend/Tests/Functional/Rendering/ScriptAndLinkTagRenderingTest.php+1 −2
- typo3/sysext/frontend/Tests/Functional/Rendering/SvgImageRenderingTest.php+1 −2
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+1 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/PageTypeDecoratorTest.php+2 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php+2 −3
- typo3/sysext/frontend/Tests/Functional/Tca/BackendLayoutVisibleFieldsTest.php+3 −3
- typo3/sysext/frontend/Tests/Functional/Tca/ContentVisibleFieldsTest.php+2 −3
- typo3/sysext/frontend/Tests/Functional/Tca/FrontendGroupsVisibleFieldsTest.php+2 −3
- typo3/sysext/frontend/Tests/Functional/Tca/FrontendUsersVisibleFieldsTest.php+2 −3
- typo3/sysext/frontend/Tests/Functional/Tca/PagesLanguageOverlayVisibleFieldsTest.php+2 −3
- typo3/sysext/frontend/Tests/Functional/Tca/TemplateVisibleFieldsTest.php+2 −3
- typo3/sysext/impexp/Tests/Functional/Import/ImagesWithStoragesTest.php+2 −2
- typo3/sysext/impexp/Tests/Functional/Import/IrreRecordsTest.php+1 −2
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentTest.php+1 −2
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInEmptyDatabaseTest.php+9 −9
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php+11 −12
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithRteImagesAndFileLinkTest.php+1 −2
- typo3/sysext/impexp/Tests/Functional/ImportExportTest.php+1 −2
- typo3/sysext/indexed_search/Tests/Functional/Utility/LikeWildcardTest.php+1 −2
- typo3/sysext/indexed_search/Tests/Functional/IndexSearchRepositoryTest.php+1 −2
- typo3/sysext/install/Tests/Functional/Updates/RowUpdater/SysRedirectRootPageMoveMigrationTest.php+1 −1
- typo3/sysext/install/Tests/Functional/Updates/SysFileCollectionIdentifierMigrationTest.php+1 −2
- typo3/sysext/install/Tests/Functional/Updates/SysFileMountIdentifierMigrationTest.php+1 −2
- typo3/sysext/lowlevel/Tests/Functional/Clean/CleanUpLocalProcessedFilesTest.php+2 −2
- typo3/sysext/lowlevel/Tests/Functional/Controller/DatabaseIntegrityControllerTest.php+4 −5
- typo3/sysext/reactions/Tests/Functional/Reaction/CreateRecordReactionTest.php+3 −3
- typo3/sysext/redirects/Tests/Functional/Controller/ManagementControllerTest.php+1 −2
- typo3/sysext/redirects/Tests/Functional/EventListener/AddPageTypeZeroSourceTest.php+3 −3
- typo3/sysext/redirects/Tests/Functional/EventListener/AddPlainSlugReplacementSourceTest.php+1 −2
- typo3/sysext/redirects/Tests/Functional/Repository/RedirectRepositoryTest.php+1 −2
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+1 −1
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+3 −3
- typo3/sysext/rte_ckeditor/Tests/Functional/RecordList/Controller/BrowseLinksControllerTest.php+1 −2
- typo3/sysext/scheduler/Tests/Functional/Task/ExecuteSchedulableCommandAdditionalFieldProviderTest.php+2 −2
- typo3/sysext/scheduler/Tests/Functional/Tca/TaskGroupVisibleFieldsTest.php+2 −3
- typo3/sysext/seo/Tests/Functional/MetaTag/MetaTagGeneratorTest.php+4 −5
- typo3/sysext/workspaces/Tests/Functional/EventListener/PageTreeItemsHighlighterTest.php+1 −2
- typo3/sysext/workspaces/Tests/Functional/Tca/WorkspaceStageVisibleFieldsTest.php+2 −3
- typo3/sysext/workspaces/Tests/Functional/Tca/WorkspaceVisibleFieldsTest.php+2 −3
Review log 812
-
Anja Leichsenring uploaded patch set 1 06/21/24, 11:11
-
core-ci voted on patch set 1 V -1 06/21/24, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59994
-
Anja Leichsenring uploaded patch set 2
V -106/21/24, 11:18 -
core-ci voted on patch set 2 V +1 06/21/24, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59995
-
Christian Kuhn uploaded patch set 3
V +106/21/24, 12:22 -
core-ci voted on patch set 3 V +1 06/21/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60012
-
Christian Kuhn uploaded patch set 4
V +106/21/24, 12:38 -
core-ci voted on patch set 4 V +1 06/21/24, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60014
-
Christian Kuhn voted on patch set 4 CR +1 V +1 06/21/24, 12:45
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 06/21/24, 12:47
-
Stefan Bürk voted on patch set 4 CR +2 V +2 06/21/24, 12:52
-
Stefan Bürk merged patch set 5 06/21/24, 12:53