Review main Merged

84819[TASK] Avoid unsetting variables in test tearDown()

Christian Kuhn CR +2 V +2 Hard +427 −562 updated 06/21/24, 12:01

Commit message

Recent phpunit versions improved memory handling a lot,
core tests no longer need to unset test case properties
manually.

The patch improves a couple of tests to get rid of
manual unset() in tearDown() by either simply removing
the calls, or by refactoring class properties away
altogether, which reduces mental load when reading
tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 711

  1. Christian Kuhn uploaded patch set 1 06/21/24, 11:24

  2. Christian Kuhn uploaded patch set 2 06/21/24, 11:31

  3. core-ci voted on patch set 1 V -1 06/21/24, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59996

  4. core-ci voted on patch set 2 V +1 06/21/24, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59999

  5. Christian Kuhn updated the commit message in patch set 3 V +1 06/21/24, 11:45

  6. Anja Leichsenring voted on patch set 3 CR +1 V +1 06/21/24, 11:48

  7. core-ci voted on patch set 3 V +1 06/21/24, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60002

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 06/21/24, 12:00

  9. core-ci commented on patch set 3 06/21/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60003

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 06/21/24, 12:01

  11. Christian Kuhn merged patch set 4 06/21/24, 12:01