Review main Merged

84821[BUGFIX] Correct link color for workspace module link in toolbar

Benjamin Kott CR +2 V +2 Easy +2 −8 updated 06/21/24, 14:15

Commit message

Using the forced primary link colors in dark mode on dark
backgrounds generates insufficient contrast. In addition,
we let the general module link handler handle the switch
to the module.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1216

  1. Benjamin Kott uploaded patch set 1 06/21/24, 11:30

  2. core-ci voted on patch set 1 V +1 06/21/24, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59998

  3. Oli Bartsch commented on patch set 1 06/21/24, 11:56

    DropDown.html:8

    Since this is a link, we should either add a target (`href="{f:be.uri(route: 'workspaces_admin')}"`) or change to button.
  4. Jasmina Ließmann updated the commit message in patch set 2 V +1 06/21/24, 12:58

  5. Jasmina Ließmann voted on patch set 2 V +1 06/21/24, 12:58

  6. Benjamin Kott commented on patch set 1 06/21/24, 13:01

    DropDown.html:8 Reply

    this patch is not changing that behaviour and we have similar already in the systeminformation dropdown. we can for sure add routes here, but we should streamline all usages then.
  7. Jasmina Ließmann voted on patch set 2 CR +1 06/21/24, 13:06

  8. core-ci voted on patch set 2 V -1 06/21/24, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60019

  9. core-ci voted on patch set 2 V +1 06/21/24, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60019

  10. Christian Kuhn commented on patch set 2 CR +1 V +1 06/21/24, 13:34

    DropDown.html:8 Reply

    Acknowledged
  11. Benjamin Kott updated the commit message in patch set 3 CR +1 V +1 06/21/24, 14:09

  12. Christian Kuhn voted on patch set 3 CR +1 V +1 06/21/24, 14:09

  13. Jasmina Ließmann voted on patch set 3 CR +1 V +1 06/21/24, 14:10

  14. core-ci voted on patch set 3 V +1 06/21/24, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60031

  15. Benjamin Kott voted on patch set 3 CR +2 V +2 06/21/24, 14:15

  16. Benjamin Kott merged patch set 4 06/21/24, 14:15