Review 12.4 Merged

84823[BUGFIX] Properly handle checkbox state changes in FormEngine

Oli Bartsch CR +2 V +2 Easy +6 −3 updated 06/21/24, 11:56

Commit message

Using the multi record selection, it's possible
to change the state of checkboxes via multiple
ways, e.g. by clicking on the table row.

The central functionality for changing the
connected checkbox state now also considers
the disabled attribute and therefore only
changes the checked state in case the
checkbox is not disabled.

Additionally, next to the custom event, which
is triggered on checkbox state changes, the
multi record selection now also dispatches
the standard "change" event. FormEngine
validation for example is listening on
this event to mark the field as changed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch uploaded patch set 1 06/21/24, 11:43

  2. core-ci voted on patch set 1 V +1 06/21/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60001

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 06/21/24, 11:56

  4. Oli Bartsch merged patch set 2 06/21/24, 11:56