Review main Merged

84827[TASK] Streamline `TYPO3\CMS\Core\Database\Schema\SchemaMigrator`

Stefan Bürk CR +2 V +2 Normal +117 −70 updated 06/21/24, 16:35

Commit message

This change streamlines the `SchemaMigrator`, mainly
moving code from the `parseCreateTableStatements()`
method into dedicated methods. Divide and conquer.

Acts as preparation for better schema migration and
side effecet free test refactoring.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Markus Hofmann +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Markus Hofmann +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Stefan Bürk uploaded patch set 1 06/21/24, 12:04

  2. core-ci voted on patch set 1 V +1 06/21/24, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60007

  3. Stefan Bürk uploaded patch set 2 V +1 06/21/24, 16:21

  4. Christian Kuhn voted on patch set 2 CR +1 V +1 06/21/24, 16:25

  5. core-ci voted on patch set 2 V +1 06/21/24, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60039

  6. Markus Hofmann voted on patch set 2 CR +1 V +1 06/21/24, 16:30

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 06/21/24, 16:30

  8. Stefan Bürk merged patch set 3 06/21/24, 16:35