Review main Merged

84831[TASK] Avoid backupGlobals=true in deprecated unit tests

Christian Kuhn CR +2 V +2 Easy +0 −1 updated 06/21/24, 13:33

Commit message

Not globally setting backupGlobals=true speeds up
unit tests quite significantly. We can do this with
deprecated unit tests without further issues already.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Christian Kuhn uploaded patch set 1 06/21/24, 13:03

  2. Andreas Kienast voted on patch set 1 CR +1 06/21/24, 13:07

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 06/21/24, 13:07

  4. core-ci voted on patch set 1 V +1 06/21/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60020

  5. Andreas Kienast voted on patch set 1 V +1 06/21/24, 13:12

  6. Andreas Kienast commented on patch set 1 06/21/24, 13:14

    Hmm, according to the Gitlab stats, it is now twice as slow: https://git.typo3.org/typo3/CI/cms/-/jobs/3432169 vs. https://git.typo3.org/typo3/CI/cms/-/jobs/3432049
  7. Andreas Kienast commented on patch set 1 06/21/24, 13:19

    Reply

    nvm, the "Duration" of the job is much higher than in previous builds, but phpunit is indeed faster...
  8. core-ci commented on patch set 1 06/21/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60021

  9. Christian Kuhn commented on patch set 1 06/21/24, 13:33

    Reply

    yeah. it also can't be measured very well with this small amount of tests. it will have a much bigger impact on unit tests, but those require more work, so we started with the simple stuff ;)
  10. Christian Kuhn voted on patch set 1 CR +2 V +2 06/21/24, 13:33

  11. Christian Kuhn merged patch set 2 06/21/24, 13:33