Review 12.4 Merged

84841[BUGFIX] Trim email address in EmailFinisher

Oli Bartsch CR +2 V +2 Easy +2 −0 updated 06/25/24, 08:33

Commit message

The ext:form EmailFinisher allows to retreive
recipients via different ways. Next to the
default yaml configuration is it also possible
to set recipients via flexform or via TypoScript.

In such cases there might be additional whitespaces
added, which would lead to the function not returning
the recipients address since GU:validEmail() would
fail. Since recipients are mandatory, this leads
to an exception in the finisher.

To prevent such "false positives", the address is
now trimmed before being checked.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 06/24/24, 20:14

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/24/24, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60202

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 06/25/24, 08:33

  4. Oli Bartsch merged patch set 2 06/25/24, 08:33