Review 12.4 Merged

84842[BUGFIX] Silence regexp pattern errors in EXT:redirects

Stefan Bürk CR +2 V +2 Easy +4 −2 updated 06/25/24, 08:31

Commit message

This change adds a `@` silence operator to the usage of
`preg_match()` in the `RedirectService`. This prevents errors
in case of manually-entered malformed regexp patterns and follows
existing similar usages of the service.

Additionally, a todo comment is added to evaluate future early
pattern evaluation in record creation/editing so that
a proper response to invalid patterns can be emitted.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 06/25/24, 08:19

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/25/24, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60273

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 06/25/24, 08:31

  4. Stefan Bürk merged patch set 2 06/25/24, 08:31