Review 12.4 Merged

84852[BUGFIX] Fix imageManipulation allowedAspectRatios with "." notation

Christian Kuhn CR +2 V +2 Easy +28 −1 updated 06/21/24, 13:37

Commit message

Internally, all allowedAspectRatios will replace a "." character
with "_" to prevent problems with Fluid variable key access.

The lead to a situation that the backend was unable to reference
the current selectedRatio, because the comparison was not
performed on the "fixed" key name.

This patch now uses a central "fix" method Ratio::prepareAspectRatioId
in both the value object preparation as well as the configuration
instantiation.

This workaround should be addressed as a breaking change in
TYPO3v14, a note has been added.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/21/24, 13:26

  2. core-ci voted on patch set 1 V +1 06/21/24, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60023

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/21/24, 13:37

  4. Christian Kuhn merged patch set 2 06/21/24, 13:37