Review main Abandoned

84853[WIP][TASK] Avoid backupGlobals=true in unit tests

Christian Kuhn CR 0 V 0 Hard +749 −0 updated 07/08/24, 16:05

Commit message

WIP!

> Build/Scripts/runTests.sh -s unit -- -c Build/phpunit/UnitTestsNoBackupGlobals.xml

Review

  • Code review CR 0
  • Verified V 0

Files 6

Review log 811

  1. Christian Kuhn uploaded patch set 1 06/21/24, 13:59

  2. Christian Kuhn updated the commit message in patch set 2 06/21/24, 13:59

  3. core-ci voted on patch set 1 V +1 06/21/24, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60026

  4. core-ci voted on patch set 2 V +1 06/21/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60027

  5. Christian Kuhn uploaded patch set 3 V +1 06/21/24, 14:20

  6. Christian Kuhn commented on patch set 3 06/21/24, 14:21

    this will become quite painful to fully get right. unsure if we should follow this path right now.
  7. core-ci voted on patch set 3 V +1 06/21/24, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60033

  8. Christian Kuhn voted on patch set 3 CR -1 06/21/24, 14:33

  9. Oliver Klee commented on patch set 3 06/23/24, 12:01

    I'd be fine with keeping the current state as-is (i.e., without this change). As far as I understand it, disabling backupGlobals slightly improves performance for the tests. And I consider the unit test "fast enough", and AFAIK the backupGlobals is not the bottleneck for the functional and acceptance tests. (There, I suspect the DB, creating the dummy TYPO3 installation, and the headless browser.)
  10. Christian Kuhn commented on patch set 3 07/08/24, 16:05

    Reply

    going without backupGlobals would be better, and the speed improvement is actually quite significant. however, with the remaining globals used by core: be_user, tca, lang, it becomes quite tedious to get rid of backupGlobals at the moment ... abandoning.
  11. Christian Kuhn abandoned the change 07/08/24, 16:05