84853[WIP][TASK] Avoid backupGlobals=true in unit tests
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 6
- Build/phpunit/UnitTestsNoBackupGlobals.xmlnew+737 −0
- typo3/sysext/backend/Tests/Unit/Controller/EditDocumentControllerTest.php+4 −0
- typo3/sysext/backend/Tests/Unit/Form/FieldWizard/TableListTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseDefaultLanguagePageRowTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseLanguageRowsTest.php+2 −0
Review log 811
-
Christian Kuhn uploaded patch set 1 06/21/24, 13:59
-
Christian Kuhn updated the commit message in patch set 2 06/21/24, 13:59
-
core-ci voted on patch set 1 V +1 06/21/24, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60026
-
core-ci voted on patch set 2 V +1 06/21/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60027
-
Christian Kuhn uploaded patch set 3
V +106/21/24, 14:20 -
Christian Kuhn commented on patch set 3 06/21/24, 14:21
this will become quite painful to fully get right. unsure if we should follow this path right now. -
core-ci voted on patch set 3 V +1 06/21/24, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60033
-
Christian Kuhn voted on patch set 3 CR -1 06/21/24, 14:33
-
Oliver Klee commented on patch set 3 06/23/24, 12:01
I'd be fine with keeping the current state as-is (i.e., without this change). As far as I understand it, disabling backupGlobals slightly improves performance for the tests. And I consider the unit test "fast enough", and AFAIK the backupGlobals is not the bottleneck for the functional and acceptance tests. (There, I suspect the DB, creating the dummy TYPO3 installation, and the headless browser.) -
Christian Kuhn commented on patch set 3 07/08/24, 16:05
Reply
going without backupGlobals would be better, and the speed improvement is actually quite significant. however, with the remaining globals used by core: be_user, tca, lang, it becomes quite tedious to get rid of backupGlobals at the moment ... abandoning. -
Christian Kuhn abandoned the change 07/08/24, 16:05