Review main Merged

84855[BUGFIX] Transform ISO code of countries to its name in EXT:form

Georg Ringer CR +2 V +2 Easy +8 −0 updated 12/17/24, 09:07

Commit message

Using a country select field in EXT:form should always show the
name of the country and not its ISO2 code.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Georg Ringer uploaded patch set 1 06/22/24, 05:40

  2. Georg Ringer commented on patch set 1 06/22/24, 05:40

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 06/22/24, 05:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60062

  4. Oli Bartsch commented on patch set 1 06/22/24, 07:27

    RenderFormValueViewHelper.php:114

    Let's make this explicit, checking for either the class or being not null.
  5. Georg Ringer commented on patch set 1 06/23/24, 10:37

    RenderFormValueViewHelper.php:114 Reply

    Done
  6. Georg Ringer commented on patch set 2 V +1 07/27/24, 18:21

    Published edit on patch set 1.
  7. core-ci voted on patch set 2 V -1 07/27/24, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62316

  8. Benni Mack updated the commit message in patch set 3 V -1 10/18/24, 13:39

  9. Benni Mack rebased onto patch set 4 12/04/24, 11:30

  10. core-ci voted on patch set 4 V +1 12/04/24, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70583

  11. Oli Bartsch voted on patch set 4 CR +1 V +1 12/17/24, 08:08

  12. Benni Mack voted on patch set 4 CR +2 V +2 12/17/24, 09:07

  13. Benni Mack merged patch set 5 12/17/24, 09:07