Review main Abandoned

84861[WIP][FEATURE] Create notifications from standardized structs

Andreas Kienast CR 0 V 0 Hard +504 −308 updated 06/24/24, 06:21

Commit message

The Notification currently consists of some static methods with a loose
set of parameters. This commit updates the API with a new standardized
struct class, describing the notification, which is passed to the new
`Notification.fromStruct()` method.

The `NotificationStruct` struct object can be created by either calling
its constructor, or calling its static `fromPayload()` method, which
accepts a payload object. Also, notification structs can be exported and
re-used later on.

TODO:
* Migrate deprecated calls

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 70

Show 50 more files

Review log 59

  1. Andreas Kienast uploaded patch set 1 06/23/24, 10:05

  2. core-ci voted on patch set 1 V +1 06/23/24, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60094

  3. Andreas Kienast uploaded patch set 2 V +1 06/23/24, 11:56

  4. core-ci voted on patch set 2 V +1 06/23/24, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60103

  5. Andreas Kienast uploaded patch set 3 V +1 06/23/24, 15:31

  6. Andreas Kienast updated the commit message in patch set 4 06/23/24, 15:31

  7. core-ci voted on patch set 4 V -1 06/23/24, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60120

  8. core-ci voted on patch set 3 V -1 06/23/24, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60119

  9. Andreas Kienast abandoned the change 06/24/24, 06:21

    too complicated