84862[FEATURE] Provide tsconfig file inclusion for be_users & be_groups
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Guido Schmechel +1
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Guido Schmechel +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php+41 −17
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php1+45 −12
- typo3/sysext/core/Configuration/TCA/be_groups.php3+11 −1
- typo3/sysext/core/Configuration/TCA/be_users.php2+12 −2
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-78412-ProvideStaticTsconfigIncludesForBe_usersBe_groups.rstnew+77 −0
- typo3/sysext/core/Resources/Private/Language/locallang_tca.xlf+3 −0
Review log 3556
Show 2031 earlier messages
-
Georg Ringer uploaded patch set 1 06/23/24, 12:24
-
Georg Ringer commented on patch set 1 06/23/24, 12:24
This change is ready for review. -
core-ci voted on patch set 1 V +1 06/23/24, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60105
-
Stefan Bürk commented on patch set 1 06/23/24, 16:52
be_groups.php:230Should the HIDE_FOR_NON_ADMINS condition not be added here ? ``` 'displayCond' => 'HIDE_FOR_NON_ADMINS', ```be_users.php:312Should the HIDE_FOR_NON_ADMINS condition not be added here ? ``` 'displayCond' => 'HIDE_FOR_NON_ADMINS', ```Feature-78412-ProvideStaticTsconfigIncludesForBe_usersBe_groups.rst:14line breaks -
Georg Ringer commented on patch set 1 06/23/24, 17:13
be_groups.php:230Replybe_groups can only be edited by admins anyway ;) -
Georg Ringer uploaded patch set 2
V +112/19/24, 18:22 -
Georg Ringer uploaded patch set 3 12/19/24, 18:23
-
core-ci voted on patch set 3 V +1 12/19/24, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71469
-
core-ci voted on patch set 2 V +1 12/19/24, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71468
-
Georg Ringer rebased onto patch set 4
V +102/03/25, 19:50 -
core-ci voted on patch set 4 V +1 02/03/25, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73442
-
Georg Ringer rebased onto patch set 5
V +102/19/25, 10:47 -
core-ci voted on patch set 5 V +1 02/19/25, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74370
-
Benni Mack uploaded patch set 6
V +103/22/25, 14:12 -
Benni Mack commented on patch set 6 CR +1 03/22/25, 14:12
be_groups.php:230ReplyDonebe_users.php:312ReplyDoneFeature-78412-ProvideStaticTsconfigIncludesForBe_usersBe_groups.rst:14ReplyDone -
Benni Mack commented on patch set 6 CR 0 03/22/25, 14:14
Even though the patch is good in its way, I don't see the benefit of doing so, I'd rather have the deployable permission presets in place to mix and match such parts (https://review.typo3.org/c/Packages/TYPO3.CMS/+/85577). In addition. I try to set such stuff always on the group-level, and try to avoid everything on be_users level (even though userTS is arguably a grey-area) -
core-ci voted on patch set 6 V +1 03/22/25, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76023
-
Benni Mack commented on patch set 6 03/28/25, 12:38
Reply
I am fine to have it in, if somebody is willing to review and test? -
Simon Schaufelberger uploaded patch set 7
V +110/01/25, 19:49 -
Simon Schaufelberger uploaded patch set 8 10/01/25, 19:54
-
core-ci voted on patch set 7 V +1 10/01/25, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85837
-
core-ci voted on patch set 8 V +1 10/01/25, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85838
-
Georg Ringer uploaded patch set 9
V +111/20/25, 20:18 -
core-ci voted on patch set 9 V +1 11/20/25, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90369
-
Georg Ringer uploaded patch set 10
V +112/29/25, 17:50 -
Georg Ringer uploaded patch set 11 12/29/25, 17:57
-
core-ci voted on patch set 10 V +1 12/29/25, 17:58 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 11 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92784
-
core-ci voted on patch set 11 V +1 12/29/25, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92785
-
Josef Glatz updated the commit message in patch set 12
V +112/31/25, 09:08 -
Josef Glatz updated the commit message in patch set 13 12/31/25, 09:11
-
Josef Glatz updated the commit message in patch set 14 12/31/25, 09:12
-
core-ci voted on patch set 12 V +1 12/31/25, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92837
-
core-ci voted on patch set 13 V +1 12/31/25, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92838
-
core-ci voted on patch set 14 V +1 12/31/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92839
-
Josef Glatz commented on patch set 14 CR -1 12/31/25, 10:07
On it -
Josef Glatz commented on patch set 15
CR -1V +112/31/25, 11:29Published edit on patch set 14. -
Josef Glatz updated the commit message in patch set 16 12/31/25, 11:31
-
Josef Glatz updated the commit message in patch set 17 12/31/25, 11:32
-
Josef Glatz commented on patch set 18 12/31/25, 11:33
Published edit on patch set 17. -
Josef Glatz commented on patch set 18 CR +1 12/31/25, 11:37
Feature-78412-ProvideStaticTsconfigIncludesForBe_usersBe_groups.rst:75added some real life scenarios because I see too much User TSconfig in the DB in TYPO3 instances where automatic deployment is used but kauderwelsch is going on in fields like pages.TSconfig or be_groups.TSconfig ;-) -
core-ci voted on patch set 15 V +1 12/31/25, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92840
-
core-ci voted on patch set 16 V +1 12/31/25, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92841
-
core-ci voted on patch set 17 V -1 12/31/25, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92842
-
core-ci voted on patch set 18 V +1 12/31/25, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92843
-
Josef Glatz updated the commit message in patch set 19
CR +1V +101/01/26, 06:49 -
Josef Glatz voted on patch set 19 CR +1 01/01/26, 06:50
-
core-ci voted on patch set 19 V +1 01/01/26, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92869
-
Josef Glatz commented on patch set 20
CR +1V +101/05/26, 06:56Published edit on patch set 19. -
Josef Glatz voted on patch set 20 CR +1 V +1 01/05/26, 06:56
-
core-ci voted on patch set 20 V +1 01/05/26, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92957
-
Georg Ringer uploaded patch set 21
CR +1V +101/23/26, 20:03 -
core-ci voted on patch set 21 V +1 01/23/26, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94205
-
Guido Schmechel commented on patch set 21 CR +1 V +1 01/25/26, 09:11
Nice! :-) -
Garvin Hicking commented on patch set 21 CR +1 V +1 02/26/26, 20:24
ExtensionManagementUtility.php:1003UnresolvedI hate @throws annotations, they're always outdated. ;) -
Georg Ringer voted on patch set 21 CR +2 V +2 02/26/26, 21:19
-
Georg Ringer merged patch set 22 02/26/26, 21:19