Review main Merged

84863[BUGFIX] Use correct reference record for new button

Stefan Froemken CR +2 V +2 Easy +11 −5 updated 12/16/24, 10:57

Commit message

In case the "multiple record edit" mode in FormEngine
is used, the new button now properly respects this
by using the last record's uid, except "insert
record on top" is defined. Therefore, the new
record is added below the last record of the
current edit view.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1217

  1. Stefan Froemken uploaded patch set 1 06/23/24, 14:52

  2. core-ci voted on patch set 1 V -1 06/23/24, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60114

  3. Stefan Froemken uploaded patch set 2 V -1 06/23/24, 15:01

  4. core-ci voted on patch set 2 V +1 06/23/24, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60115

  5. Riccardo De Contardi commented on patch set 2 V +1 06/23/24, 15:17

    tested with - "edit this column" in Page view - "edit columns" and "edit" in List view
  6. Benni Mack updated the commit message in patch set 3 V +1 10/24/24, 09:13

  7. core-ci voted on patch set 3 V -1 10/24/24, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68520

  8. Benni Mack rebased onto patch set 4 V -1 11/22/24, 14:41

  9. core-ci voted on patch set 4 V +1 11/22/24, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70044

  10. Benni Mack voted on patch set 4 CR +1 V +1 11/22/24, 15:29

  11. Oli Bartsch commented on patch set 4 V -1 11/22/24, 17:31

    Why do we not fix this => using the last record for creating the new one?
  12. Oli Bartsch uploaded patch set 5 CR +1 V +1 12/16/24, 10:25

  13. Oli Bartsch commented on patch set 5 12/16/24, 10:25

    Reply

    Done
  14. Oli Bartsch voted on patch set 5 CR +1 V +1 12/16/24, 10:25

  15. core-ci voted on patch set 5 V +1 12/16/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71178

  16. Benni Mack voted on patch set 5 CR +2 V +2 12/16/24, 10:57

  17. Benni Mack merged patch set 6 12/16/24, 10:57