Review main Merged

84864[TASK] Avoid implicitly nullable class method parameter in `EXT:redirects`

Stefan Bürk CR +2 V +2 Easy +5 −5 updated 06/24/24, 05:06

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is depreacted and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator. [1]

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 78

  1. Stefan Bürk uploaded patch set 1 06/23/24, 15:26

  2. core-ci voted on patch set 1 V +1 06/23/24, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60116

  3. Oliver Klee voted on patch set 1 V +1 06/23/24, 15:36

  4. Oliver Klee voted on patch set 1 CR +1 06/23/24, 15:36

  5. Stefan Bürk commented on patch set 1 06/23/24, 16:32

    Note that backports needs review and voting too, not only the main change.
  6. Garvin Hicking voted on patch set 1 CR +1 V +1 06/23/24, 22:06

  7. Georg Ringer voted on patch set 1 CR +2 V +2 06/24/24, 05:06

  8. Georg Ringer merged patch set 2 06/24/24, 05:06