Review main Merged

84867[TASK] Avoid implicitly nullable class method parameter in `EXT:workspaces`

Stefan Bürk CR +2 V +2 Easy +24 −24 updated 06/24/24, 13:38

Commit message

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator. [1]

This prepares the way towards PHP 8.4 compatibility and
unifies towards using `?` nullable operator over union
null type when possible.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1012

  1. Stefan Bürk uploaded patch set 1 06/23/24, 15:36

  2. Oliver Klee voted on patch set 1 CR +1 06/23/24, 15:38

  3. core-ci voted on patch set 1 V +1 06/23/24, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60121

  4. Oliver Klee voted on patch set 1 V +1 06/23/24, 15:53

  5. Stefan Bürk commented on patch set 1 06/23/24, 16:32

    Note that backports needs review and voting too, not only the main change.
  6. Garvin Hicking voted on patch set 1 CR +1 V +1 06/23/24, 22:09

  7. Benni Mack updated the commit message in patch set 2 CR +1 V +1 06/24/24, 06:22

  8. core-ci voted on patch set 2 V +1 06/24/24, 06:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60149

  9. Oli Bartsch voted on patch set 2 CR +1 V +1 06/24/24, 06:46

  10. Garvin Hicking voted on patch set 2 CR +1 V +1 06/24/24, 06:59

  11. Stefan Bürk voted on patch set 2 CR +2 V +2 06/24/24, 13:38

  12. Stefan Bürk merged patch set 3 06/24/24, 13:38